Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulled the latest gopowerstore changes #353

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Pulled the latest gopowerstore changes #353

merged 1 commit into from
Oct 11, 2024

Conversation

rajendraindukuri
Copy link
Contributor

@rajendraindukuri rajendraindukuri commented Oct 10, 2024 •
edited
Loading

Description

  • Updated code to consume latest gopowerstore changes
  • Updated unit tests for the same

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1443

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Ran unit tests

image

@rajendraindukuri rajendraindukuri marked this pull request as ready for review October 10, 2024 07:52
@rajendraindukuri rajendraindukuri force-pushed the pulling-latest-gopowerstore-changes branch from 6d4e800 to 3d98c59 Compare October 11, 2024 05:52
@rajendraindukuri
Pulled the latest gopowerstore changes for sync
7c914b3 
Signed-off-by: Indukuri <rajendra.indukuri@dell.com>
@rajendraindukuri rajendraindukuri force-pushed the pulling-latest-gopowerstore-changes branch from 3d98c59 to 7c914b3 Compare October 11, 2024 11:32
@rajendraindukuri rajendraindukuri merged commit 3e49910 into main Oct 11, 2024
5 checks passed
@AronAtDell AronAtDell deleted the pulling-latest-gopowerstore-changes branch October 17, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshatdell santhoshatdell santhoshatdell approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@chimanjain chimanjain chimanjain approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rajendraindukuri @chimanjain @nitesh3108 @AkshaySainiDell @adarsh-dell @santhoshatdell