Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSI driver-initiated pause and resume on metro volumes #360

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

lukeatdell
Copy link
Contributor

@lukeatdell lukeatdell commented Oct 21, 2024

Description

Removing CSI driver-initiated pause and resume actions for metro replication session during volume expansion operations.
User must now pause the metro session from the PowerStore UI before initiating a volume expansion request within Kubernetes and resume the metro session after the PVC reflects the updated size.

Removed unit tests that were no longer relevant to the implementation.
coverage percentage has been maintained

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1443

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

Testing

StorageClass for testing:
image

Manual Volume Expansion

  • Created and applied a metro storage class with allowVolumeExpansion: true.
  • Created a pod with 8Gi PVC and waited for the PV to be provisioned.
  • Paused the metro session for the volume from the PowerStore UI.
  • Initiated the expand-volume request by editing the PVC from 8Gi to 20Gi, and noted the change reflected in the PV.
  • Resumed the metro session for the volume from the PowerStore UI.
  • After the metro session state returned to 'Operating Normally (Active-Active), noted the PVC also reflected the new volume size (about 3m from the time the resume operation occurred).
  • Performed a write operation in the directory mounted via the PVC.

Cert-csi

PowerStore Metro

Performed cert-csi testing with below tests to confirm no regressions were introduced for PowerStore Metro Volumes.
image
image

PowerStore Block ext4

Performed cert-csi testing with below tests to confirm no regressions were introduced for PowerStore ext4 block volumes.
image
image
image

@lukeatdell lukeatdell merged commit fbdb65e into main Oct 21, 2024
5 checks passed
@lukeatdell lukeatdell deleted the usr/lukeatdell/metro-resize branch October 21, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants