Bugfix/nvme volume expansion #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshitap26
requested review from
bpjain2004,
francis-nijay,
harishp8889,
kumarp20,
prablr79,
spriya-m and
gilltaran
as code owners
prablr79
reviewed
Mar 2, 2022
| for _, device := range devMnt.DeviceNames { | ||
| devicePath := sysBlock + device | ||
| err = s.Fs.GetUtil().DeviceRescan(context.Background(), devicePath) | ||
| if err != nil { |
There was a problem hiding this comment.
can you remove some extra lines here.
There was a problem hiding this comment.
@prablr79 only the if condition has been added to the previous code (if s.useFC || s.useISCSI )
francis-nijay
approved these changes
Mar 2, 2022
spriya-m
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR for the bugfix on NVMe Volume Expansion.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration