Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NVMe Ephemeral Changes #68

Merged
merged 3 commits into from
Mar 7, 2022
Merged

NVMe Ephemeral Changes #68

merged 3 commits into from
Mar 7, 2022

Conversation

harshitap26
Copy link
Contributor

Description

go.mod reference update for latest gobrick and gonvme changes for ephemeral pod bugfix.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#158

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built successfully and ran tests - All the tests are passing

spriya-m
spriya-m previously approved these changes Mar 7, 2022
View reviewed changes
prablr79
prablr79 previously approved these changes Mar 7, 2022
View reviewed changes
harishp8889
harishp8889 requested changes Mar 7, 2022
View reviewed changes
Copy link
Collaborator

@harishp8889 harishp8889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshitap26 Please update the gobrick with latest main commit [b392bd0](https://github.com/dell/gobrick/commit/b392bd0f7d1d007c7a12e260d008d88cd42e1bdf)

@harshitap26 harshitap26 dismissed stale reviews from prablr79 and spriya-m via c547717 March 7, 2022 06:09
@harshitap26 harshitap26 requested a review from harishp8889 March 7, 2022 06:14
@harishp8889 harishp8889 merged commit c92ee70 into main Mar 7, 2022
@harishp8889 harishp8889 deleted the bugfix/nvme-ephemeral-changes branch March 8, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spriya-m spriya-m spriya-m approved these changes

@harishp8889 harishp8889 harishp8889 approved these changes

@prablr79 prablr79 prablr79 left review comments

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@gilltaran gilltaran Awaiting requested review from gilltaran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshitap26 @harishp8889 @prablr79 @spriya-m