Changes for k3s Debian support #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikk92
requested review from
Deepak-Ghivari,
francis-nijay,
bandak2,
rajendraindukuri,
rensyct and
panigs7
as code owners
karthikk92
changed the title
karthikk92
changed the title
panigs7
previously approved these changes
May 15, 2023
rensyct
reviewed
May 15, 2023
| @@ -147,12 +146,6 @@ func (s *service) NodeStageVolume( | |||
| volumeLUNAddress: hlu, | |||
| } | |||
|
|
|||
| if hlu == LUNZHLU { | |||
There was a problem hiding this comment.
Can we remove the definition of LUNZHLU if not used anywhere else
rensyct
approved these changes
May 15, 2023
panigs7
approved these changes
May 15, 2023
bandak2
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes for k3s Debian support
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Tested for both k3s Debian system with 1.25 and 1.26 version
also Tested with k8s environment to make sure k8s environment test cases working fine.