Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gobrick module update #225

Merged
merged 1 commit into from
Aug 8, 2024
Merged

gobrick module update #225

merged 1 commit into from
Aug 8, 2024

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Aug 8, 2024 •
edited
Loading

Description

gobrick module update for the scsi rescan fix dell/gobrick#54

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1379

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • driver pods running with latest gobrick
    image

  • cert-csi
    image

@suryagupta4
gobrick update
f3f3a44 
Signed-off-by: Surya <surya.gupta1@dell.com>
@suryagupta4 suryagupta4 self-assigned this Aug 8, 2024
adarsh-dell
adarsh-dell approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suryagupta4 suryagupta4 merged commit d2774c2 into main Aug 8, 2024
4 checks passed
@suryagupta4 suryagupta4 deleted the golibupdate branch August 8, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

Assignees

@suryagupta4 suryagupta4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suryagupta4 @rajendraindukuri @AkshaySainiDell @adarsh-dell