Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Observability with Authorization helm deployment and other minor fixes #121

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Update Observability with Authorization helm deployment and other minor fixes #121

merged 2 commits into from
Jan 13, 2022

Conversation

atye
Copy link
Contributor

@atye atye commented Jan 6, 2022

Description

CSM-Authorization is deprecating sidecar injection so the sidecarproxyaddr in the configuration is being removed. This also notes the necessary mountEndpoint field in the csi-isilon secret if CSM-Authorization is enabled and fixes some misleading documentation.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#112

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@atye atye changed the title fix mountEndpoint references Fix mountEndpoint references and remove sidecarproxyaddr configuration Jan 6, 2022
@tdawe
Copy link
Contributor

tdawe commented Jan 6, 2022

Should this target a release branch instead of main?

@tdawe
Copy link
Contributor

tdawe commented Jan 6, 2022

Since injection is being removed, the documentation also contains other references to using inject. Can those references be deleted as part of this PR? Or will there be another PR?

@atye atye changed the base branch from main to release-1.2 January 6, 2022 19:25
@atye
Copy link
Contributor Author

atye commented Jan 6, 2022

Should this target a release branch instead of main?

I think you're right. This PR targets release-1.2 now.

@atye
Copy link
Contributor Author

atye commented Jan 6, 2022

Since injection is being removed, the documentation also contains other references to using inject. Can those references be deleted as part of this PR? Or will there be another PR?

They can be deleted on this PR. Working on that.

@atye atye mentioned this pull request Jan 6, 2022
Merged
3 tasks
@atye
Copy link
Contributor Author

atye commented Jan 6, 2022 •
edited
Loading

Since injection is being removed, the documentation also contains other references to using inject. Can those references be deleted as part of this PR? Or will there be another PR?

They can be deleted on this PR. Working on that.

@tdawe Pushed changes removing references of injection. A good chunk of troubleshooting was removed.

@atye atye changed the title Fix mountEndpoint references and remove sidecarproxyaddr configuration Update Observability with Authorization helm deployment and other minor fixes Jan 7, 2022
@atye atye merged commit 3a9ea86 into release-1.2 Jan 13, 2022
@atye atye deleted the fix-mountEndpoint-references branch January 13, 2022 18:05
karthikk92 pushed a commit that referenced this pull request Feb 25, 2022
@atye @karthikk92
Update Observability with Authorization helm deployment and other min…
4e931f3 
…or fixes (#121)

* fix mountEndpoint references

* add docs for auth with observability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdawe tdawe tdawe approved these changes

@hoppea2 hoppea2 hoppea2 approved these changes

@alikdell alikdell alikdell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atye @tdawe @hoppea2 @alikdell