Use sed as alternative to jq #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatwork
requested review from
gallacher,
mjsdell,
prablr79,
rajendraindukuri,
rsedlock1958 and
shanmydell
as code owners
rsedlock1958
reviewed
Aug 2, 2022
| @@ -13,7 +13,7 @@ The following CSM Authorization components are installed in the specified namesp | |||
| - role-service, which configures roles for tenants to be bound to | |||
| - storage-service, which configures backend storage arrays for the proxy-server to foward requests to | |||
|
|
|||
| The folloiwng third-party components are installed in the specified namespace: | |||
| The following third-party components are installed in the specified namespace: | |||
There was a problem hiding this comment.
Change ""The following" to "These"
rsedlock1958
reviewed
Aug 2, 2022
| @@ -215,10 +215,10 @@ karavictl generate token --tenant Finance --insecure --addr tenant.csm-authoriza | |||
| } | |||
| ``` | |||
|
|
|||
| With [jq](https://stedolan.github.io/jq/), you process the above response to filter the secret manifest. For example: | |||
| Process the above response to filter the secret manifest. For example using sed you can run the following: | |||
There was a problem hiding this comment.
Delete "above". Change "the following" to "this"
rsedlock1958
reviewed
Aug 2, 2022
shanmydell
approved these changes
Aug 4, 2022
sharmilarama
approved these changes
Aug 4, 2022
shaynafinocchiaro
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add alternative method to extract the token and convert to YAML format. Added note in both Helm and RPM deployment sections. There are more than one way to do this but felt that sed is in all major distributions and not everyone may use Python's json module which is another option I thought about.
Testing
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: