Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upgrade docs pflex #309

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Fix upgrade docs pflex #309

merged 5 commits into from
Aug 16, 2022

Conversation

JacobGros
Copy link
Contributor

@JacobGros JacobGros commented Aug 11, 2022 •
edited
Loading

Description

This PR adds documentation for the spec.fsGroupPolicy: Invalid value: "xxx": field is immutable issue some people see when upgrading.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#357

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

bharathsreekanth
bharathsreekanth previously approved these changes Aug 11, 2022
View reviewed changes
Copy link

@bharathsreekanth bharathsreekanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would help if you can describe what the issue is in the description.

rsedlock1958
rsedlock1958 reviewed Aug 11, 2022
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this and made one minor comment.

mbasha-dell
mbasha-dell previously approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@mbasha-dell mbasha-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

shanmydell
shanmydell requested changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls verify links via hugo

jooseppi-luna
jooseppi-luna previously approved these changes Aug 11, 2022
View reviewed changes
@JacobGros
Copy link
Contributor Author

JacobGros commented Aug 15, 2022 •
edited
Loading

pls verify links via hugo

Fixed link and verified via hugo

@jooseppi-luna jooseppi-luna self-requested a review August 15, 2022 18:11
@JacobGros JacobGros requested a review from shanmydell August 16, 2022 13:13
@shanmydell shanmydell merged commit eec4bbc into release-1.4-updated Aug 16, 2022
@shanmydell shanmydell deleted the fix-upgrade-docs-pflex branch August 16, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jooseppi-luna jooseppi-luna jooseppi-luna approved these changes

@mjsdell mjsdell mjsdell approved these changes

@shanmydell shanmydell shanmydell approved these changes

@bharathsreekanth bharathsreekanth bharathsreekanth left review comments

@mbasha-dell mbasha-dell mbasha-dell left review comments

@gallacher gallacher Awaiting requested review from gallacher

@prablr79 prablr79 Awaiting requested review from prablr79

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@karthikk92 karthikk92 Awaiting requested review from karthikk92

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JacobGros @jooseppi-luna @mjsdell @rsedlock1958 @shanmydell @bharathsreekanth @mbasha-dell