Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug-410]: Authorization backup and restore #320

Merged
merged 4 commits into from
Aug 23, 2022

Conversation

atye
Copy link
Contributor

@atye atye commented Aug 18, 2022

Description

Adds documentation for backing up and restoring Authorization data.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#410

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

tdawe
tdawe previously approved these changes Aug 18, 2022
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. There are two minor edits required.


Redis is used to store application data regarding [tenants, quota, and volume ownership](../../design#quota--volume-ownership) with the Storage Class specified in the `redis.storageClass` parameter in the values file, or with the default Storage Class if that parameter was not specified.

The Persistent Volume for Redis is dynamically provisioned by this Storage Class with the `redis-primary-pv-claim` Persistent Volume Claim. See the example below.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete "below"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.


Redis is used to store application data regarding [tenants, quota, and volume ownership](../../design#quota--volume-ownership). This data is stored on the system under `/var/lib/rancher/k3s/storage/<redis-primary-pv-claim-volume-name>/appendonly.aof`.

`appendonly.aof` can be copied and used to restore this appliation data in Authorization deployments. See the example below.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete "below"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

description: >
Dell Technologies (Dell) Container Storage Modules (CSM) for Authorization Helm backup and restore
---

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of repeating "In the deployment of Authorization that you want to restore" for each step, can we put this snippet before listing the steps for Roles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue with that is that step 1 is ran in the original deployment to save the resource. Would having sections for steps to execute on the original deployment vs the new deployment work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with sections for the different deployments.

description: >
Dell Technologies (Dell) Container Storage Modules (CSM) for Authorization RPM backup and restore
---

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here for RPM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with sections for the different deployments.

Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atye atye merged commit 26c118b into release-1.4-updated Aug 23, 2022
@atye atye deleted the bug-410-auth-redis branch August 23, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants