Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Powerflex Replication #445

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Powerflex Replication #445

merged 4 commits into from
Feb 14, 2023

Conversation

falfaroc
Copy link
Contributor

@falfaroc falfaroc commented Feb 2, 2023 •
edited
Loading

Description

Add the documentation related to enabling Replication on PowerFlex.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#618

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

rsedlock1958
rsedlock1958 reviewed Feb 2, 2023
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. No grammatical edits are required.

rajkumar-palani
rajkumar-palani reviewed Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@falfaroc -

  1. Demo link is not working, remove it. don't give the internal IPs.
  2. Can you please also correct the typo (update as "Replication") given in the description.

shanmydell
shanmydell previously requested changes Feb 3, 2023
View reviewed changes
content/docs/replication/_index.md Outdated Show resolved Hide resolved
content/docs/replication/deployment/installation.md Outdated Show resolved Hide resolved
content/docs/replication/_index.md Outdated Show resolved Hide resolved
content/docs/replication/deployment/powerflex.md Show resolved Hide resolved
content/docs/replication/deployment/powerflex.md Outdated Show resolved Hide resolved
rajkumar-palani
rajkumar-palani previously requested changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete the Peer Review on the changes done and get the approval.

content/docs/replication/_index.md Show resolved Hide resolved
@falfaroc falfaroc changed the title Powerflex replication Powerflex Replication Feb 6, 2023
@falfaroc falfaroc force-pushed the powerflex-replication branch from 86ca38d to d73934a Compare February 8, 2023 19:06
rsedlock1958
rsedlock1958 reviewed Feb 8, 2023
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. Several edits are required.

@falfaroc falfaroc force-pushed the powerflex-replication branch from d73934a to 4e878d1 Compare February 8, 2023 21:26
@falfaroc falfaroc requested a review from rsedlock1958 February 8, 2023 21:27
rsedlock1958
rsedlock1958 reviewed Feb 8, 2023
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. It looks good. No grammatical edits are required.

@falfaroc falfaroc force-pushed the powerflex-replication branch from 4e878d1 to afda994 Compare February 9, 2023 16:19
rsedlock1958
rsedlock1958 reviewed Feb 9, 2023
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. One edit is required.

@falfaroc falfaroc force-pushed the powerflex-replication branch from afda994 to 6768d70 Compare February 10, 2023 16:32
rsedlock1958
rsedlock1958 reviewed Feb 10, 2023
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. No edits are required.

@falfaroc falfaroc dismissed stale reviews from shanmydell and rajkumar-palani February 10, 2023 18:11

Adjusted accordingly.

santhoshatdell
santhoshatdell previously approved these changes Feb 10, 2023
View reviewed changes
@falfaroc
Copy link
Contributor Author

I have reviewed this. No edits are required.

@rsedlock1958 Please approve if no further changes are needed.

rajkumar-palani
rajkumar-palani previously requested changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshaatdell - can you please review this PR?

content/docs/replication/_index.md Outdated Show resolved Hide resolved
content/docs/replication/_index.md Outdated Show resolved Hide resolved
content/docs/replication/_index.md Outdated Show resolved Hide resolved
rsedlock1958
rsedlock1958 approved these changes Feb 14, 2023
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. No grammatical edits are required.

@harshaatdell
Copy link
Contributor

@harshaatdell - can you please review this PR?

Done

@falfaroc falfaroc merged commit 97c77f5 into release-1.6.0 Feb 14, 2023
rajkumar-palani pushed a commit that referenced this pull request Feb 27, 2023
@falfaroc @rajkumar-palani
Powerflex Replication (#445)
b6f7d0e 
* Add PowerFlex replication documentation

* Update PowerFlex replication docs

* Fix documentation

* Updated compatible versions
rajkumar-palani pushed a commit that referenced this pull request Mar 9, 2023
@falfaroc @rajkumar-palani
Powerflex Replication (#445)
68b5495 
* Add PowerFlex replication documentation

* Update PowerFlex replication docs

* Fix documentation

* Updated compatible versions
@shanmydell shanmydell deleted the powerflex-replication branch July 20, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshaatdell harshaatdell harshaatdell approved these changes

@rsedlock1958 rsedlock1958 rsedlock1958 approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@gallacher gallacher Awaiting requested review from gallacher

@mjsdell mjsdell Awaiting requested review from mjsdell

@prablr79 prablr79 Awaiting requested review from prablr79

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@shanmydell shanmydell Awaiting requested review from shanmydell

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@falfaroc @harshaatdell @rajkumar-palani @rsedlock1958 @shanmydell @santhoshatdell