-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update replication.md #503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -16,12 +16,12 @@ To use Replication, you need at least two clusters: | |||
|
|||
To configure all the clusters, follow the steps below: | |||
|
|||
1. On your main cluster, follow the instructions available in CSM Replication for [Installation using repctl](../../../replication/deployment/install-repctl.md). NOTE: On step 4 of the link above, you MUST use the command below to automatically package all clusters' `.kube` config as a secret: | |||
1. On your main cluster, follow the instructions available in CSM Replication for [Installation using repctl](../../../../replication/deployment/install-repctl). NOTE: On step 4 of the link above, you MUST use the command below to automatically package all clusters' `.kube` config as a secret: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be a note. This should be a distinct step instruction. Change to read "On your main cluster, follow the instructions available in CSM Replication for Installation using repctl, with the exception of step 4. When you reach step 4, you MUST use the command below to automatically package all clusters' .kube
config as a secret:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will address this as recommended. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a major edit required.
Description
This PR is to address the broken links in replication readme file
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: