Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update replication.md #503

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Update replication.md #503

merged 1 commit into from
Mar 2, 2023

Conversation

anandrajak1
Copy link
Collaborator

@anandrajak1 anandrajak1 commented Mar 2, 2023

Description

This PR is to address the broken links in replication readme file

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
685

Checklist:

  • [ X] Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anandrajak1 anandrajak1 merged commit 15eaeac into main Mar 2, 2023
@@ -16,12 +16,12 @@ To use Replication, you need at least two clusters:

To configure all the clusters, follow the steps below:

1. On your main cluster, follow the instructions available in CSM Replication for [Installation using repctl](../../../replication/deployment/install-repctl.md). NOTE: On step 4 of the link above, you MUST use the command below to automatically package all clusters' `.kube` config as a secret:
1. On your main cluster, follow the instructions available in CSM Replication for [Installation using repctl](../../../../replication/deployment/install-repctl). NOTE: On step 4 of the link above, you MUST use the command below to automatically package all clusters' `.kube` config as a secret:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a note. This should be a distinct step instruction. Change to read "On your main cluster, follow the instructions available in CSM Replication for Installation using repctl, with the exception of step 4. When you reach step 4, you MUST use the command below to automatically package all clusters' .kube config as a secret:"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will address this as recommended. Thanks.

Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a major edit required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants