Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance fix #119

Merged
merged 2 commits into from
Jan 10, 2025
Merged

performance fix #119

merged 2 commits into from
Jan 10, 2025

Conversation

nitesh3108
Copy link
Contributor

Description

Fix the performance issues while fetching the metrics and looping issue

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UTs passed
    image (1)

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No
image image

@csmbot
Copy link
Collaborator

csmbot commented Jan 10, 2025

Can one of the admins verify this patch?

Signed-off-by: nitesh3108 <nitesh_rewatkar@dell.com>
Signed-off-by: nitesh3108 <nitesh_rewatkar@dell.com>
@nitesh3108 nitesh3108 merged commit 11abb45 into main Jan 10, 2025
8 checks passed
@nitesh3108 nitesh3108 deleted the revamp-otel-performance branch January 10, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants