Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reading maxPowerStoreConcurrentRequests #136

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

X4mp
Copy link

@X4mp X4mp commented Feb 4, 2025

Description

Reading POWERSTORE_MAX_CONCURRENT_QUERIES from config doesn't work. The variable is shadowed inside an if statement due to reduntante short hand declaration. I've added a new variable similar to the updateTickIntervals function which is set to maxPowerStoreConcurrentRequests.

GitHub Issues

List the GitHub issues impacted by this PR:
There are no issues in this repository

GitHub Issue #
none

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Due to the FATAL logging in error cases, this has been tested manually.
In addition I've added two test cases for success cases.

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

Roland Urbano added 2 commits February 4, 2025 12:08
Signed-off-by: Roland Urbano <roland.urbano@nts.eu>
Signed-off-by: Roland Urbano <roland.urbano@nts.eu>
@csmbot
Copy link
Collaborator

csmbot commented Feb 4, 2025

Can one of the admins verify this patch?

@X4mp
Copy link
Author

X4mp commented Feb 4, 2025

I didn't check the Grafana Dashboards as we use Grafana 11 and the CSM dashboards are only supported with <= Grafana 10. But the changes are minimal so impact to the dashboards isn't expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants