Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x/net package #48

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

baoy1
Copy link
Contributor

@baoy1 baoy1 commented Mar 14, 2023

Description

Update x/net package.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#583

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • make check test
➜ make check test
./scripts/check.sh ./cmd/... ./opentelemetry/... ./internal/...
=== Checking format...
=== Finished
=== Vetting...
=== Finished
=== Linting...
=== Finished
=== Running gosec...
=== Finished
go test -count=1 -cover -race -timeout 30s -short ./...
?       github.com/dell/csm-metrics-powerstore/cmd/metrics-powerstore   [no test files]
ok      github.com/dell/csm-metrics-powerstore/internal/common  0.174s  coverage: 91.7% of statements
ok      github.com/dell/csm-metrics-powerstore/internal/entrypoint      0.708s coverage: 91.4% of statements
?       github.com/dell/csm-metrics-powerstore/internal/k8s/mocks       [no test files]
ok      github.com/dell/csm-metrics-powerstore/internal/k8s     0.077s  coverage: 91.8% of statements
?       github.com/dell/csm-metrics-powerstore/internal/service/mocks   [no test files]
?       github.com/dell/csm-metrics-powerstore/opentelemetry/exporters  [no test files]
?       github.com/dell/csm-metrics-powerstore/opentelemetry/exporters/mocks   [no test files]
?       github.com/dell/csm-metrics-powerstore/opentelemetry/tracers    [no test files]
ok      github.com/dell/csm-metrics-powerstore/internal/service 0.076s  coverage: 90.3% of statements

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@baoy1
Copy link
Contributor Author

baoy1 commented Mar 14, 2023

run e2e test

1 similar comment
@baoy1
Copy link
Contributor Author

baoy1 commented Mar 14, 2023

run e2e test

Copy link
Collaborator

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - please proceed with the merge

@forrestxia forrestxia merged commit 236817f into release-v1.5.0 Mar 15, 2023
@forrestxia forrestxia deleted the feature-583-obs-update-xnet branch March 15, 2023 01:49
@forrestxia forrestxia restored the feature-583-obs-update-xnet branch March 18, 2023 08:33
baoy1 added a commit that referenced this pull request Mar 27, 2023
@anandrajak1 anandrajak1 deleted the feature-583-obs-update-xnet branch October 17, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants