fix lint errors

dell · Aug 27, 2024 · 6f609ca · 6f609ca
1 parent 832e000
commit 6f609ca
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 11 deletions.
diff --git a/api/v1/acc_types.go b/api/v1/acc_types.go
@@ -13,8 +13,6 @@
 package v1
 
 import (
-	"fmt"
-
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
@@ -78,7 +76,7 @@ func (cr *ApexConnectivityClient) GetApexConnectivityClientStatus() *ApexConnect
 
 // GetApexConnectivityClientName - Returns the Client
 func (cr *ApexConnectivityClient) GetApexConnectivityClientName() string {
-	return fmt.Sprintf("%s", cr.Name)
+	return cr.Name
 }
 
 // GetApexConnectivityClientSpec - Returns a pointer to the GetApexConnectivityClientSpec instance

diff --git a/pkg/modules/application_mobility.go b/pkg/modules/application_mobility.go
@@ -560,7 +560,7 @@ func AppMobilityVelero(ctx context.Context, isDeleting bool, op utils.OperatorCo
 			return err
 		}
 
-		volumeSnapshotLoc, err := utils.GetVolumeSnapshotLocation(ctx, vsName, cr.Namespace, ctrlClient)
+		volumeSnapshotLoc, _ := utils.GetVolumeSnapshotLocation(ctx, vsName, cr.Namespace, ctrlClient)
 		if volumeSnapshotLoc != nil {
 			log.Infow("\n Volume Snapshot location Name : ", volumeSnapshotLoc.Name, " already exists and being re-used")
 		}
@@ -571,7 +571,7 @@ func AppMobilityVelero(ctx context.Context, isDeleting bool, op utils.OperatorCo
 		}
 
 		for _, ctrlObj := range ctrlObjects {
-			if isDeleting == false {
+			if !isDeleting {
 				if err := utils.ApplyObject(ctx, ctrlObj, ctrlClient); err != nil {
 					return err
 				}
@@ -794,7 +794,7 @@ func UseBackupStorageLoc(ctx context.Context, isDeleting bool, op utils.Operator
 		return err
 	}
 
-	backupStorageLoc, err := utils.GetBackupStorageLocation(ctx, bslName, cr.Namespace, ctrlClient)
+	backupStorageLoc, _ := utils.GetBackupStorageLocation(ctx, bslName, cr.Namespace, ctrlClient)
 	if backupStorageLoc != nil {
 		log.Infow("\n Backup Storage Name : ", backupStorageLoc.Name, "already exists and being re-used")
 	}
@@ -805,7 +805,7 @@ func UseBackupStorageLoc(ctx context.Context, isDeleting bool, op utils.Operator
 	}
 
 	for _, ctrlObj := range ctrlObjects {
-		if isDeleting == false {
+		if !isDeleting {
 			if err := utils.ApplyObject(ctx, ctrlObj, ctrlClient); err != nil {
 				return err
 			}

diff --git a/pkg/utils/utils.go b/pkg/utils/utils.go
@@ -220,7 +220,6 @@ func ReplaceAllContainerImageApply(img K8sImagesConfig, c *acorev1.ContainerAppl
 	case string(csmv1.Resiliency):
 		*c.Image = img.Images.Podmon
 	}
-	return
 }
 
 // UpdateinitContainerApply -

diff --git a/tests/shared/clientgoclient/fakeDaemonset.go b/tests/shared/clientgoclient/fakeDaemonset.go
@@ -40,7 +40,7 @@ func (c *FakeDaemonSets) Apply(ctx context.Context, daemonSet *applyconfiguratio
 		return result, err
 	}
 
-	err = json.Unmarshal(data, result)
+	_ = json.Unmarshal(data, result)
 
 	_, err = c.Get(ctx, *daemonSet.Name, v1.GetOptions{})
 	if errors.IsNotFound(err) {

diff --git a/tests/shared/clientgoclient/fakeDeployment.go b/tests/shared/clientgoclient/fakeDeployment.go
@@ -43,7 +43,7 @@ func (c *FakeDeployments) Apply(ctx context.Context, deployment *applyconfigurat
 		return result, err
 	}
 
-	err = json.Unmarshal(data, result)
+	_ = json.Unmarshal(data, result)
 
 	_, err = c.Get(ctx, *deployment.Name, v1.GetOptions{})
 	if errors.IsNotFound(err) {

diff --git a/tests/shared/clientgoclient/fakeStatefulset.go b/tests/shared/clientgoclient/fakeStatefulset.go
@@ -43,7 +43,7 @@ func (c *FakeStatefulsets) Apply(ctx context.Context, statefulset *applyconfigur
 		return result, err
 	}
 
-	err = json.Unmarshal(data, result)
+	_ = json.Unmarshal(data, result)
 
 	_, err = c.Get(ctx, *statefulset.Name, v1.GetOptions{})
 	if errors.IsNotFound(err) {
-Original file line number
+Diff line change
@@ Expand Up @@
     	case string(csmv1.Resiliency):
     		*c.Image = img.Images.Podmon
     	}
-    	return
     }
     // UpdateinitContainerApply -
@@ Expand Down @@