Add PowerFlex Unit Tests to pkg/drivers #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into pflex-unit-test merge remote into local
jooseppi-luna
changed the title
jooseppi-luna
requested review from
abhi16394,
alikdell,
bharathsreekanth,
coulof,
Deepak-Ghivari,
gallacher,
JacobGros,
nb950,
karthikk92,
bandak2,
mjsdell,
rajendraindukuri,
rensyct,
panigs7 and
tdawe
as code owners
mbasha-dell
previously approved these changes
Oct 28, 2022
bharathsreekanth
approved these changes
Oct 28, 2022
mbasha-dell
approved these changes
Oct 28, 2022
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
* breaking test code into multiple files * coverage up to 91.4 * removed dead code added test * cleaning up code * reset test coverage threshold * fixed format and lint * added _ to read err * minor changes * fix merge issues * make merge work * adding Abrar and Karthik to codeowners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for pkg/drivers to cover powerflex.go. Also broke tests out into three files instead of having everything in commonconfig.go. Coverage on powerflex.go went from 0.0% -> 98.8%. Total package coverage went from 65% to 95%.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Ran unit tests and confirmed passing. Also looked at go coverage reports.
Built new image based on my changes, installed it and successfully ran e2e tests on it.