Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sample certificates for Observability documentation #126

Merged
merged 2 commits into from
Nov 8, 2022
Merged

add sample certificates for Observability documentation #126

merged 2 commits into from
Nov 8, 2022

Conversation

YianZong
Copy link
Contributor

@YianZong YianZong commented Nov 7, 2022 •
edited
Loading

Description

Added sample certificates for Observability documentation

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#488

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Manually created certificates from samples
    image

@YianZong YianZong marked this pull request as ready for review November 7, 2022 13:51
forrestxia
forrestxia previously approved these changes Nov 8, 2022
View reviewed changes
taohe1012
taohe1012 previously approved these changes Nov 8, 2022
View reviewed changes
rensyct
rensyct reviewed Nov 8, 2022
View reviewed changes
samples/observability/custom-cert.yaml Outdated
renewBefore: 360h # 15d
subject:
organizations:
- dellemc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to dell

samples/observability/selfsigned-cert.yaml Outdated
renewBefore: 360h # 15d
subject:
organizations:
- dellemc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S comment as above

samples/observability/selfsigned-cert.yaml Outdated
renewBefore: 360h # 15d
subject:
organizations:
- dellemc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

samples/observability/custom-cert.yaml Outdated
renewBefore: 360h # 15d
subject:
organizations:
- dellemc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rensyct ! Changed all 'dellemc' to 'dell'.

@YianZong YianZong dismissed stale reviews from taohe1012 and forrestxia via 0398750 November 8, 2022 10:20
@YianZong YianZong force-pushed the feature-488-cert-sample branch from c4c3a93 to 0398750 Compare November 8, 2022 10:20
@YianZong YianZong merged commit f92bfe6 into main Nov 8, 2022
@YianZong YianZong deleted the feature-488-cert-sample branch November 8, 2022 11:01
@YianZong YianZong linked an issue Nov 24, 2022 that may be closed by this pull request
[FEATURE]: CSM Operator: Support install of Observability dell/csm#488
Closed
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
add sample certificates for Observability documentation (#126)
822eabd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forrestxia forrestxia forrestxia approved these changes

@rensyct rensyct rensyct approved these changes

@taohe1012 taohe1012 taohe1012 left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@nb950 nb950 Awaiting requested review from nb950

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao

@baoy1 baoy1 Awaiting requested review from baoy1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: CSM Operator: Support install of Observability
4 participants
@YianZong @rensyct @taohe1012 @forrestxia