Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing var to testfiles #131

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Add missing var to testfiles #131

merged 3 commits into from
Nov 8, 2022

Conversation

JacobGros
Copy link
Contributor

@JacobGros JacobGros commented Nov 8, 2022 •
edited
Loading

Description

Add missing env variable to testfiles

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#477

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran e2e tests to make sure files were usable when no cert secrets were on array

mjsdell
mjsdell approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@mjsdell mjsdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JacobGros JacobGros changed the title Add e2e fix Add missing var to testfiles Nov 8, 2022
@JacobGros JacobGros merged commit 153fda8 into main Nov 8, 2022
@JacobGros JacobGros deleted the add-e2e-fix branch November 8, 2022 23:12
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Add missing var to testfiles (#131)
01a9b97 
* Update storage_csm_powerflex.yaml

* Update storage_csm_powerflex_auth.yaml

* Update storage_csm_powerflex_observability.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjsdell mjsdell mjsdell approved these changes

@jooseppi-luna jooseppi-luna jooseppi-luna approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@nb950 nb950 Awaiting requested review from nb950

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rensyct rensyct Awaiting requested review from rensyct

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacobGros @jooseppi-luna @mjsdell