Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Powerflex config map name in manifests #149

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Conversation

rensyct
Copy link
Contributor

@rensyct rensyct commented Dec 5, 2022

Description

This PR corrects Powerflex config map name in samples and test files

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#491

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

karthikk92
karthikk92 previously approved these changes Dec 5, 2022
Copy link
Contributor

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to discuss this in Moose scrum- will update based on discussions

@rensyct
Copy link
Contributor Author

rensyct commented Dec 5, 2022

need to discuss this in Moose scrum- will update based on discussions

Note: ConfigMap name in https://github.com/dell/csm-operator/blob/main/samples/storage_csm_powerflex_v230.yaml is vxflexos-config-params and does not match with what is there is 2.4 and 2.5 samples.

@JacobGros
Copy link
Contributor

talked about it in scrum-
2.3 version in samples/ needs fixing.

If you look at node.yaml and other files, we are looking for name to be test-vxflexos-xxxx
even in 2.3 files:

name: <DriverDefaultReleaseName>-config-params

name: <DriverDefaultReleaseName>-config-params

@rensyct rensyct dismissed stale reviews from karthikk92 and rajendraindukuri via 739ca1d December 5, 2022 19:32
Copy link
Contributor

@kumarkgosa kumarkgosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@rensyct rensyct merged commit 1005033 into main Dec 5, 2022
@rensyct rensyct deleted the powerflex_samples branch January 11, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants