Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit for Adding powerstore support #152

Closed
wants to merge 1 commit into from
Closed

Initial commit for Adding powerstore support #152

wants to merge 1 commit into from

Conversation

karthikk92
Copy link
Collaborator

Description

Initial commit for Adding powerstore support which has initial dependency on further testing

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#613

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@panigs7 panigs7 self-requested a review January 13, 2023 07:47
rensyct
rensyct suggested changes Jan 13, 2023
View reviewed changes
api/v1/types.go
@@ -80,6 +80,9 @@ const (
// PowerStore - placeholder for constant powerstore
PowerStore DriverType = "powerstore"

// PowerStoreName - placeholder for constant PowerStore
PowerStoreName DriverType = "powerstore"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kk3, why are we adding PowerStoreName when we have PowerStore at Line No 81. Also the constant name is same in both the cases

@karthikk92 karthikk92 closed this Jan 13, 2023
@karthikk92 karthikk92 deleted the powerstore_support_api_types branch January 19, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rensyct rensyct rensyct requested changes

@panigs7 panigs7 panigs7 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikk92 @rensyct @panigs7