Ensure that the fields mentioned in samples are configurable. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikk92
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
coulof,
Deepak-Ghivari,
gallacher,
JacobGros,
jooseppi-luna,
kumarkgosa,
bandak2,
mjsdell,
rajendraindukuri,
rensyct,
panigs7 and
tdawe
as code owners
rensyct
reviewed
Feb 13, 2023
pkg/drivers/powerstore.go
Outdated
| log.Debugw("preCheck", "secrets", len(secrets)) | ||
| return nil | ||
| } | ||
|
|
||
| // ModifyPowerstoreCR - | ||
| func ModifyPowerstoreCR(YamlString string, cr csmv1.ContainerStorageModule, file_type string) string { |
There was a problem hiding this comment.
Please maintain the naming convention for variables
pkg/drivers/powerstore.go
Outdated
| nfsacls := "" | ||
| healthmonitor_controller := "" | ||
| chap := "" | ||
| healthmonitor_node := "" |
There was a problem hiding this comment.
Same comment as above for all the variables declared from Line No 84-89
|
@karthikk92 , Please ensure to rebase your branch and also fix the linting issues |
karthikk92
force-pushed
the
configPar
branch
3 times, most recently
from
67af051 to
49db8c5
Compare
rensyct
suggested changes
Feb 14, 2023
| - name: X_CSI_POWERSTORE_CONFIG_PATH | ||
| value: /powerstore-config/config | ||
| - name: X_CSI_POWERSTORE_CONFIG_PARAMS_PATH | ||
| value: /powerstore-config-params/driver-config-params.yaml | ||
| - name: GOPOWERSTORE_DEBUG | ||
| value: "true" | ||
| - name: X_CSI_HEALTH_MONITOR_ENABLED | ||
| value: "false" | ||
| value: "<X_CSI_HEALTH_MONITOR_ENABLED>" |
There was a problem hiding this comment.
@karthikk92 , Do we need quotes here
karthikk92
force-pushed
the
configPar
branch
from
4e58cfb to
61bc9a2
Compare
taken care |
rensyct
suggested changes
Feb 14, 2023
| mountPath: /var/lib/kubelet/plugins/kubernetes.io/csi | ||
| mountPropagation: "Bidirectional" | ||
| - name: pods-path | ||
| mountPath: /var/lib/kubelet/pods | ||
| value: "false" |
There was a problem hiding this comment.
Do we have value for volumeMounts. @kk3 please check
| - name: X_CSI_POWERSTORE_CONFIG_PATH | ||
| value: /powerstore-config/config | ||
| - name: X_CSI_POWERSTORE_CONFIG_PARAMS_PATH | ||
| value: /powerstore-config-params/driver-config-params.yaml | ||
| - name: GOPOWERSTORE_DEBUG | ||
| value: "true" | ||
| - name: X_CSI_HEALTH_MONITOR_ENABLED | ||
| value: "<X_CSI_HEALTH_MONITOR_ENABLED>" | ||
| volumeMounts: |
There was a problem hiding this comment.
@kk3, please check if volumeMounts section is duplicated in this file
rensyct
approved these changes
Feb 14, 2023
panigs7
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the fields mentioned in samples are configurable.
Fixed issue:
PV creation is not processed for csi-powerstore installed using csm-operator
Added checks to validate secrets.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: