Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume mount fails for NFS mounts for csi-powerstore deployed using csm-operator #167

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Volume mount fails for NFS mounts for csi-powerstore deployed using csm-operator #167

merged 1 commit into from
Feb 17, 2023

Conversation

karthikk92
Copy link
Collaborator

Description

Volume mount fails for NFS mounts for csi-powerstore deployed using csm-operator

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#613

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@karthikk92 karthikk92 force-pushed the nfs_pod_creation_issue branch from 76757ca to d8668fd Compare February 16, 2023 05:02
rensyct
rensyct reviewed Feb 16, 2023
View reviewed changes
samples/storage_csm_powerstore_v250.yaml Outdated
@@ -65,6 +65,12 @@ spec:
# Default value: false
- name: X_CSI_HEALTH_MONITOR_ENABLED
value: "false"
# X_CSI_HEALTH_MONITOR_ENABLED: allows to specify additional entries for hostAccess of NFS volumes. Both single IP address and subnet are valid entries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kk3, please correct the env variable name

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taken care

rensyct
rensyct reviewed Feb 16, 2023
View reviewed changes
samples/storage_csm_powerstore_v250.yaml Outdated
@@ -65,6 +65,12 @@ spec:
# Default value: false
- name: X_CSI_HEALTH_MONITOR_ENABLED
value: "false"
# X_CSI_HEALTH_MONITOR_ENABLED: allows to specify additional entries for hostAccess of NFS volumes. Both single IP address and subnet are valid entries.
# Install the 'external-health-monitor' sidecar accordingly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line as it is not related to this environment variable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take care

@karthikk92 karthikk92 force-pushed the nfs_pod_creation_issue branch 2 times, most recently from a64bf3e to ff277af Compare February 16, 2023 09:53
rensyct
rensyct reviewed Feb 16, 2023
View reviewed changes
operatorconfig/driverconfig/powerstore/v2.5.0/controller.yaml
@@ -240,7 +240,7 @@ spec:
- name: X_CSI_DRIVER_NAME
value: "csi-powerstore.dellemc.com"
- name: X_CSI_POWERSTORE_EXTERNAL_ACCESS
value: "None"
value: <X_CSI_POWERSTORE_EXTERNAL_ACCESS>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthikk92, should this change be done for 2.4 yaml files as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take care

rensyct
rensyct reviewed Feb 16, 2023
View reviewed changes
operatorconfig/driverconfig/powerstore/v2.4.0/controller.yaml
@@ -227,7 +227,7 @@ spec:
- name: X_CSI_DRIVER_NAME
value: "csi-powerstore.dellemc.com"
- name: X_CSI_POWERSTORE_EXTERNAL_ACCESS
value: "None"
value: <X_CSI_POWERSTORE_EXTERNAL_ACCESS>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthikk92 , please check if quotes are required or not.. if it is not required please remove for the other environment variables.. Let us be consistent

Copy link
Collaborator Author

@karthikk92 karthikk92 Feb 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quotes are not required here since driver expects without quote and expects empty value. It wont work while testing. So removed quote. Here if quotes are passed it will take as string and expects ip. For other since its required its added , for example for external health monitor its expected with quote "false" or "true" as we can see before configurable parameter this is hard coded with value "false"(with quote) .

Here expected format:

  • name: X_CSI_POWERSTORE_EXTERNAL_ACCESS
    value:

rensyct
rensyct previously approved these changes Feb 17, 2023
View reviewed changes
panigs7
panigs7 previously approved these changes Feb 17, 2023
View reviewed changes
@rajendraindukuri rajendraindukuri dismissed stale reviews from panigs7 and rensyct via 2a7ad99 February 17, 2023 07:30
@rajendraindukuri rajendraindukuri merged commit e639204 into main Feb 17, 2023
@rensyct rensyct deleted the nfs_pod_creation_issue branch July 17, 2023 12:16
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Made changes for comments section for external access variable (#167)
01a318c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rensyct rensyct rensyct approved these changes

@panigs7 panigs7 panigs7 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karthikk92 @rensyct @panigs7 @rajendraindukuri