Test variables added #178
Merged
Test variables added #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi16394
requested review from
mbasha-dell,
alikdell,
bharathsreekanth,
coulof,
Deepak-Ghivari,
gallacher,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
mjsdell,
rajendraindukuri,
rensyct,
panigs7,
tdawe,
shaynafinocchiaro,
atye and
sharmilarama
as code owners
JacobGros
reviewed
Feb 27, 2023
| @@ -104,6 +104,28 @@ spec: | |||
| # Default value: false | |||
| - name: X_CSI_HEALTH_MONITOR_ENABLED | |||
| value: "false" | |||
| # X_CSI_APPROVE_SDC_ENABLED: Enables/Disable SDC approval | |||
| # Allowed values: | |||
| # true: enable SDC approval | |||
There was a problem hiding this comment.
Can we change this comment to be more descriptive?
# true: Driver will attempt to approve restricted SDC by GUID during setup
# false: Driver will not attempt to approve restricted SDC by GUID during setup
There was a problem hiding this comment.
oh I see this is a test file- nevermind
mbasha-dell
approved these changes
Feb 27, 2023
JacobGros
approved these changes
Feb 27, 2023
bharathsreekanth
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor changes to unit-test for powerflex -2.6
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Unit-test :
--- PASS: TestCustom (22.46s)
--- PASS: TestCustom/TestAuthorizationServerReconcile (20.48s)
--- PASS: TestCustom/TestContentWatch (0.02s)
--- PASS: TestCustom/TestCsmFinalizerError (0.00s)
--- PASS: TestCustom/TestCsmPreCheckModuleError (0.00s)
--- PASS: TestCustom/TestCsmPreCheckModuleUnsupportedVersion (0.00s)
--- PASS: TestCustom/TestCsmPreCheckTypeError (0.00s)
--- PASS: TestCustom/TestCsmPreCheckVersionError (0.00s)
--- PASS: TestCustom/TestCsmUpgrade (0.17s)
--- PASS: TestCustom/TestCsmUpgradePathInvalid (0.02s)
--- PASS: TestCustom/TestCsmUpgradeSkipVersion (0.00s)
--- PASS: TestCustom/TestCsmUpgradeVersionTooOld (0.00s)
--- PASS: TestCustom/TestDeleteErrorReconcile (0.29s)
--- PASS: TestCustom/TestErrorInjection (0.42s)
--- PASS: TestCustom/TestIgnoreUpdatePredicate (0.00s)
--- PASS: TestCustom/TestOldStandAloneModuleCleanup (0.12s)
--- PASS: TestCustom/TestOldStandAloneModuleCleanup/Success_-Disable_Components (0.02s)
--- PASS: TestCustom/TestOldStandAloneModuleCleanup/Success-Enable_all_modules (0.02s)
--- PASS: TestCustom/TestOldStandAloneModuleCleanup/Success-_Disable_all_modules (0.08s)
--- PASS: TestCustom/TestPowerFlexAnnotation (0.00s)
--- PASS: TestCustom/TestPowerScaleAnnotation (0.00s)
--- PASS: TestCustom/TestPowerStoreAnnotation (0.00s)
--- PASS: TestCustom/TestReconcile (0.24s)
--- PASS: TestCustom/TestReconcileAuthorization (0.00s)
--- PASS: TestCustom/TestReconcileObservabilityError (0.00s)
--- PASS: TestCustom/TestRemoveDriver (0.58s)
--- PASS: TestCustom/TestRemoveDriver/getDriverConfig_error (0.00s)
--- PASS: TestCustom/TestRemoveDriver/delete_obj_not_found (0.02s)
--- PASS: TestCustom/TestRemoveDriver/get_SA_error (0.07s)
--- PASS: TestCustom/TestRemoveDriver/get_CR_error (0.06s)
--- PASS: TestCustom/TestRemoveDriver/get_CRB_error (0.07s)
--- PASS: TestCustom/TestRemoveDriver/get_CM_error (0.08s)
--- PASS: TestCustom/TestRemoveDriver/get_Driver_error (0.07s)
--- PASS: TestCustom/TestRemoveDriver/delete_SA_error (0.07s)
--- PASS: TestCustom/TestRemoveDriver/delete_Daemonset_error (0.08s)
--- PASS: TestCustom/TestRemoveDriver/delete_Deployment_error (0.07s)
--- PASS: TestCustom/TestRemoveModule (0.11s)
--- PASS: TestCustom/TestRemoveModule/csm (0.11s)
PASS
coverage: 88.6% of statements
ok command-line-arguments 22.508s coverage: 88.6% of statements