Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create manifests that can be used in scripts for installing and uninstalling operator #19

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

rensyct
Copy link
Contributor

@rensyct rensyct commented Feb 2, 2022

Description

Create manifests that can be used in install/uninstall scripts

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Install Operator
image

Pod status
image

Uninstall Operator
image

@rensyct rensyct changed the title Create manifests for operator install Create manifests that can be used in scripts for installing and uninstalling operator Feb 2, 2022
medegw01
medegw01 previously approved these changes Feb 2, 2022
deploy/csm-operator.yaml Outdated Show resolved Hide resolved
@nb950
Copy link
Contributor

nb950 commented Feb 2, 2022

1 can you update the README at the top level with steps to use this ?
2 if there is an existing csm instance like powerscale driver is deployed, delete will not work , finalizer has to be removed and then delete operator - pls document this
3 if we make a change to csm types.go --what are the steps to generate these yamls --can you add to wiki or internals section of readme ?

@rensyct
Copy link
Contributor Author

rensyct commented Feb 3, 2022

1 can you update the README at the top level with steps to use this ? 2 if there is an existing csm instance like powerscale driver is deployed, delete will not work , finalizer has to be removed and then delete operator - pls document this 3 if we make a change to csm types.go --what are the steps to generate these yamls --can you add to wiki or internals section of readme ?

I have created a task https://jira.cec.lab.emc.com/browse/KRV-2833 to update the Readme section. This will be taken care in another PR

nb950
nb950 previously approved these changes Feb 3, 2022
@rensyct rensyct force-pushed the create_manifests_for_install branch from 7fc2b1c to 787c540 Compare February 4, 2022 10:16
@rensyct rensyct merged commit daadc98 into main Feb 4, 2022
@rensyct rensyct deleted the create_manifests_for_install branch March 21, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants