Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CSI-PowerFlex deployment #238

Merged
merged 3 commits into from
May 17, 2023
Merged

fix CSI-PowerFlex deployment #238

merged 3 commits into from
May 17, 2023

Conversation

JacobGros
Copy link
Contributor

@JacobGros JacobGros commented May 16, 2023 •
edited
Loading

Description

PowerFlex install is broken in latest version of driver.
Warning Updated 0s (x13 over 22s) csm Failed install: Deployment.apps "test-vxflexos-controller" is invalid: [spec.template.spec.volumes[3].name: Required value, spec.template.spec.containers[4].volumeMounts[3].name: Not found: "certs"]
This is due to a change made to main branch recently, this PR fixes the issue.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#756

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed PFlex driver + auth sidecar with changes

rensyct
rensyct reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@rensyct rensyct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch has to be rebased

@JacobGros
Copy link
Contributor Author

Branch has to be rebased

Done

@JacobGros JacobGros merged commit 688b04d into main May 17, 2023
@JacobGros JacobGros deleted the JacobGros-patch-1 branch May 17, 2023 13:17
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
fix CSI-PowerFlex deployment (#238)
96fb4da 
* try revert change

* revert change in node section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbasha-dell mbasha-dell mbasha-dell approved these changes

@rensyct rensyct rensyct approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacobGros @rensyct @mbasha-dell