-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install and Uninstall scripts for CSM operator #24
Conversation
} | ||
|
||
function install_driver_crd() { | ||
log step "Install/Update CRDs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since log says ""Install/Update CRDs", can we have method name as install_or_update_driver_crd() or install_update_driver_crd()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
c57075d
to
26b2453
Compare
Question : As part of the new CSM operator install are you guys testing or planning to test driver install (I believe PowerScale 2.0 install will work without requiring any changes that Moose team is doing)? |
The commits aren't signed. They'll need to be signed prior to merge. |
|
||
# verify K8s configuration | ||
function verify_kubernetes() { | ||
if [ ! -f "${SCRIPTDIR}/${VERIFYSCRIPT}" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function calls verify.sh which checks for snap CRD and snapshot controller. So change the comment, function name and echo statements accordingly as we are not doing K8s version checks in verify.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Discussed offline in CSM Operator Sync-up meet. This PR handles only the installation of operator. |
44b9953
to
601001f
Compare
163d189
601001f
to
163d189
Compare
163d189
to
863d3b6
Compare
Description
This PR includes:
Note: Will cover the fix for warning message coming while installation of operator in another PR.
"Fixed the warning message and pushed in the PR. Adding the screenshots after the fix below."
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
sh install.sh - installs crd, operator and after successful installation we can see the dell-csm-operator-controller-manager pod up and running.
![install_op_latest_1](https://user-images.githubusercontent.com/92028646/153565949-db1b15f6-7abb-4ca8-81a6-38cc7fadc357.PNG)
sh uninstall.sh
![uninstall](https://user-images.githubusercontent.com/92028646/152808249-034ced4e-baeb-4ef2-b41e-f13fbd86af51.PNG)
Fixed Warning message ( kubectl apply should be used on resource created by either kubectl create --save-config or kubectl apply):
![latest_ns](https://user-images.githubusercontent.com/92028646/153565737-b8690efe-f160-47b9-aeb3-e85f4f83c6e6.PNG)