Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and Uninstall scripts for CSM operator #24

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Conversation

panigs7
Copy link
Collaborator

@panigs7 panigs7 commented Feb 7, 2022

Description

This PR includes:

  • Install script for CSM operator
  • Uninstall script for CSM operator

Note: Will cover the fix for warning message coming while installation of operator in another PR.
"Fixed the warning message and pushed in the PR. Adding the screenshots after the fix below."

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#159

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

sh install.sh - installs crd, operator and after successful installation we can see the dell-csm-operator-controller-manager pod up and running.
install_op_latest_1

install_op_latest_2

sh uninstall.sh
uninstall

Fixed Warning message ( kubectl apply should be used on resource created by either kubectl create --save-config or kubectl apply):
latest_ns

warning_msg_fix_up_2

}

function install_driver_crd() {
log step "Install/Update CRDs"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since log says ""Install/Update CRDs", can we have method name as install_or_update_driver_crd() or install_update_driver_crd()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@panigs7 panigs7 force-pushed the add-install-script branch from c57075d to 26b2453 Compare February 8, 2022 18:04
@bharathsreekanth
Copy link
Collaborator

Question : As part of the new CSM operator install are you guys testing or planning to test driver install (I believe PowerScale 2.0 install will work without requiring any changes that Moose team is doing)?

@tdawe
Copy link
Collaborator

tdawe commented Feb 8, 2022

The commits aren't signed. They'll need to be signed prior to merge.


# verify K8s configuration
function verify_kubernetes() {
if [ ! -f "${SCRIPTDIR}/${VERIFYSCRIPT}" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function calls verify.sh which checks for snap CRD and snapshot controller. So change the comment, function name and echo statements accordingly as we are not doing K8s version checks in verify.sh

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@panigs7
Copy link
Collaborator Author

panigs7 commented Feb 10, 2022

Question : As part of the new CSM operator install are you guys testing or planning to test driver install (I believe PowerScale 2.0 install will work without requiring any changes that Moose team is doing)?

Discussed offline in CSM Operator Sync-up meet. This PR handles only the installation of operator.

karthikk92
karthikk92 previously approved these changes Feb 11, 2022
tdawe
tdawe previously approved these changes Feb 11, 2022
rensyct
rensyct previously approved these changes Feb 11, 2022
@panigs7 panigs7 dismissed stale reviews from rensyct, tdawe, and karthikk92 via 163d189 February 14, 2022 06:55
karthikk92
karthikk92 previously approved these changes Feb 14, 2022
rensyct
rensyct previously approved these changes Feb 14, 2022
@panigs7 panigs7 dismissed stale reviews from rensyct and karthikk92 via 863d3b6 February 14, 2022 08:22
@rensyct rensyct merged commit f0cfa8a into main Feb 14, 2022
@rensyct rensyct deleted the add-install-script branch March 21, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants