Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csm object fails during down scale #245

Merged
merged 1 commit into from
May 19, 2023
Merged

Csm object fails during down scale #245

merged 1 commit into from
May 19, 2023

Conversation

rajendraindukuri
Copy link
Collaborator

@rajendraindukuri rajendraindukuri commented May 18, 2023 •
edited
Loading

Description

Fix for CSM object getting into failed state when we scale down deployments in csm-operator

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#816

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Tested this specific scenario by scaling down and scaling up the deployment replicas. Also ran sanity jobs on k8s 1.27 and the results look good
Scaling down to 1
image

Scaling up to 2
image

@rajendraindukuri rajendraindukuri force-pushed the csm_object_fails_during_down_scale branch 4 times, most recently from d6fda51 to f49ba8d Compare May 18, 2023 12:10
@rajendraindukuri rajendraindukuri marked this pull request as ready for review May 18, 2023 12:50
rensyct
rensyct reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@rensyct rensyct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the commit

pkg/utils/status.go Outdated
if daemonSetErr != nil && controllerErr != nil {
err = fmt.Errorf("ControllerError: %s, Daemonseterror: %s", controllerErr.Error(), daemonSetErr.Error())
log.Infof("calculate overall error msg [%s]", err.Error())
log.Infof("calculate overall Daemonseterror msg [%s]", daemonSetErr.Error())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the log statement be Daemonset error msg?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

@rajendraindukuri rajendraindukuri force-pushed the csm_object_fails_during_down_scale branch from f49ba8d to da73817 Compare May 19, 2023 09:51
@rajendraindukuri rajendraindukuri force-pushed the csm_object_fails_during_down_scale branch from da73817 to 4d087d4 Compare May 19, 2023 09:58
@rajendraindukuri rajendraindukuri requested a review from rensyct May 19, 2023 09:59
@rajendraindukuri rajendraindukuri merged commit 4c0801b into main May 19, 2023
@rensyct rensyct deleted the csm_object_fails_during_down_scale branch July 17, 2023 12:15
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Fix for csm object deployement update issue 4 scaling events (#245)
f47dab7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rensyct rensyct rensyct approved these changes

@panigs7 panigs7 panigs7 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajendraindukuri @rensyct @panigs7