-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature-1091]: Update Authorization Proxy Server Ingress and Use Local Storage for Redis by default #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atye
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
HarishH-DELL,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
mjsdell,
nitesh3108,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7,
tdawe,
shaynafinocchiaro,
sharmilarama and
shanmydell
as code owners
January 23, 2024 23:55
atye
force-pushed
the
feature-1091-authorization-ingress-redis
branch
from
January 30, 2024 15:08
2a452b8
to
338aa73
Compare
xuluna
previously approved these changes
Jan 30, 2024
tests/e2e/testfiles/authorization-templates/csm_authorization_proxy_server_default_redis.yaml
Show resolved
Hide resolved
samples/authorization/csm_authorization_proxy_server_v1100.yaml
Outdated
Show resolved
Hide resolved
shaynafinocchiaro
approved these changes
Jan 31, 2024
PeresKereotubo
approved these changes
Jan 31, 2024
EvgenyUglov
approved these changes
Jan 31, 2024
atye
force-pushed
the
feature-1091-authorization-ingress-redis
branch
from
January 31, 2024 19:03
1b26020
to
b8f8953
Compare
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
…al Storage for Redis by default (#436) * update ingress, support default redis class, start update e2e * update auth e2e * revert new line * revert new line * fix lint * update cr redis comments * fix e2e * update proxy_host comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the Authorization proxy-server ingress to enable connecting by a cluster node IP address instead of requiring one of the hostnames in the ingress, such as csm-authorization.com, because there is extra work to make a hostname like that resolve correctly. It also provisions a local volume for Redis by default if no storage class for Redis is specified.
Changes in some more detail:
Adds v1.10.0 folder for Authorization.
operatorconfig/moduleconfig/authorization/v1.10.0/ingress.yaml
contains the following lines to allow connecting by IP address (nohost
specified).Adds
operatorconfig/moduleconfig/authorization/v1.10.0/local-provisioner.yaml
which contains manifests for a local provisioning storage class and a persistent volume with said storage class. If theREDIS_STORAGE_CLASS
env variable is not provided, these resources will be created and used for Redis.Adds sample file for Authorization v1.10.0 where
REDIS_STORAGE_CLASS
is not specified by default.Adds unit test for deploying Authorization with default local storage for Redis.
Adds PROXY_HOST env variable to
tests/e2e/env-e2e-test.sh
to specify the IP or hostname of the proxy-server for karavictl instead of using hardcoded address that only resolves in a k8s cluster.Disabled cert-manager dependency in
tests/e2e/testfiles/authorization-templates/csm_authorization_proxy_server.yaml
because a prerequisite step of Install Authorization Proxy Server is creating a cert which will fail unless cert-manager is installed. So, cert-manager has to be installed before e2e and shouldn't be installed again with Authorization.Adds e2e scenario for installing Authorization using default, local storage.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
New unit test and manual e2e test.