Fix driver status #491
Merged
Fix driver status #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobGros
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
HarishH-DELL,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
mjsdell,
nitesh3108,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7,
tdawe,
shaynafinocchiaro,
atye,
sharmilarama and
shanmydell
as code owners
jooseppi-luna
previously approved these changes
Feb 22, 2024
alikdell
reviewed
Feb 23, 2024
pkg/utils/status.go
Outdated
| log.Infof("either controllerReplicas != controllerStatus.Available or nodeStatus is bad") | ||
| log.Infof("controllerReplicas", controllerReplicas) | ||
| log.Infof("either controllerStatus.Desired != controllerStatus.Available or nodeStatus is bad") | ||
| log.Infof("controllerStatus.Desired", controllerStatus.Desired) |
There was a problem hiding this comment.
It will be good if log format same as line 429-430 for line 452-453!
There was a problem hiding this comment.
updated log messages to match format + make more clear
alikdell
reviewed
Feb 23, 2024
pkg/utils/status.go
Outdated
| @@ -388,7 +403,7 @@ func calculateState(ctx context.Context, instance *csmv1.ContainerStorageModule, | |||
| newStatus.State = constants.Succeeded | |||
| // TODO: Currently commented this block of code as the API used to get the latest deployment status is not working as expected | |||
There was a problem hiding this comment.
We should clean up commented code and //TODO in PRs.
There was a problem hiding this comment.
I guess I'm ok with getting rid of this comment, since we are planning on refactoring status anyway, so we can check on controller-runtime then. Thoughts @JacobGros ?
There was a problem hiding this comment.
makes sense to me
if we ever decide we need that code again, we can look at an older operator version
alikdell
approved these changes
Feb 23, 2024
jooseppi-luna
added a commit
that referenced
this pull request
Feb 27, 2024
* check condition for ds, check desired for deployment * fix logs, clean up comments --------- Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
* check condition for ds, check desired for deployment * fix logs, clean up comments --------- Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue where a failed driver deployment would lead to a misleading CSM status
Fixes:
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration