Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove bad unit test target #493

Merged
merged 3 commits into from
Feb 23, 2024
Merged

remove bad unit test target #493

merged 3 commits into from
Feb 23, 2024

Conversation

jooseppi-luna
Copy link
Contributor

Description

In the early days of operator, we used this make target to make unit tests, but now it is outdated and not working.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
NA

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Make target doesn't exist anymore

@jooseppi-luna jooseppi-luna merged commit a352688 into main Feb 23, 2024
8 checks passed
jooseppi-luna added a commit that referenced this pull request Feb 27, 2024
@jooseppi-luna
remove dead unit test target (#493)
cf61e97
@shanmydell shanmydell deleted the remove-old-target branch June 11, 2024 10:32
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
remove dead unit test target (#493)
17b048b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimanjain chimanjain chimanjain approved these changes

@alikdell alikdell alikdell approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@gallacher gallacher Awaiting requested review from gallacher

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2

@mjsdell mjsdell Awaiting requested review from mjsdell

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

@panigs7 panigs7 Awaiting requested review from panigs7

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro

@atye atye Awaiting requested review from atye

@sharmilarama sharmilarama Awaiting requested review from sharmilarama

@shanmydell shanmydell Awaiting requested review from shanmydell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jooseppi-luna @chimanjain @alikdell