Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict access to the kube-proxy to local pod connections only #525

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Mar 14, 2024

Description

Previously merged to main via PR 516
This PR restricts the access of the kube-proxy port to only connections within the client pod.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
1029
1189

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  1. Deployed the client and validated that the access to the proxy from outside the pod, within the cluster is blocked. The service is not exported outside the cluster.

Copy link
Contributor

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

Copy link
Collaborator

@abhi16394 abhi16394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donatwork linters checks are failing
Could you check that

@donatwork
Copy link
Contributor Author

donatwork commented Mar 14, 2024

@donatwork linters checks are failing Could you check that

I made no changes to the Go code. The base branch previously had linter errors. Those were fixed in main.

@jooseppi-luna jooseppi-luna requested a review from abhi16394 March 14, 2024 18:33
Copy link
Collaborator

@abhi16394 abhi16394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donatwork donatwork merged commit c715d99 into release-v1.4.4 Mar 14, 2024
7 of 8 checks passed
@donatwork donatwork deleted the bug-1029-anc-perms branch March 14, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants