Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default container to driver #543

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Set default container to driver #543

merged 2 commits into from
Apr 22, 2024

Conversation

coulof
Copy link
Contributor

@coulof coulof commented Apr 18, 2024

Description

Make the default container to driver so it is easier to capture log and consistent with Helm Charts

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

This hasn't been tested with the Operator ; the label is present in Helm Chart since several months : https://github.com/dell/helm-charts/blame/905c3951da497421276b54540a092712dc66b2b1/charts/csi-vxflexos/templates/controller.yaml#L171

Please share the protocol to try it out if any.

abhi16394
abhi16394 previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@abhi16394 abhi16394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

donatwork
donatwork previously approved these changes Apr 22, 2024
View reviewed changes
nitesh3108
nitesh3108 previously approved these changes Apr 22, 2024
View reviewed changes
shanmydell
shanmydell previously approved these changes Apr 22, 2024
View reviewed changes
@coulof coulof dismissed stale reviews from shanmydell, nitesh3108, donatwork, and abhi16394 via 56ef4eb April 22, 2024 15:47
abhi16394
abhi16394 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@abhi16394 abhi16394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhi16394 abhi16394 merged commit 92b6220 into main Apr 22, 2024
8 checks passed
@abhi16394 abhi16394 deleted the default-container-driver branch April 22, 2024 18:28
@coulof coulof restored the default-container-driver branch April 23, 2024 14:37
rajendraindukuri pushed a commit that referenced this pull request May 17, 2024
@coulof @rajendraindukuri
Set default container to driver (#543)
94125f4 
* Set default container to driver

* Add exception for the unfixed CVE
rajendraindukuri added a commit that referenced this pull request May 20, 2024
@rajendraindukuri @dependabot
@kumarkgosa @panigs7 @shefali-malhotra @chimanjain @HarishH-DELL @coulof
Cherry picking security fixes and other commits that needs to be part…
715f356 
… of patch release (#562)

* Bump google.golang.org/protobuf from 1.30.0 to 1.33.0 (#522)

Bumps google.golang.org/protobuf from 1.30.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kumar Karthik Gosa <107932920+kumarkgosa@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
Co-authored-by: shefali-malhotra <91597668+shefali-malhotra@users.noreply.github.com>

* Bump golang.org/x/net from 0.17.0 to 0.23.0 (#544)

* Bump golang.org/x/net from 0.17.0 to 0.23.0

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0.
- [Commits](golang/net@v0.17.0...v0.23.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* update allowed list

* update allowed list

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: shefali-malhotra <91597668+shefali-malhotra@users.noreply.github.com>
Co-authored-by: Chiman Jain <chimanjain15@gmail.com>

* Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /tests/e2e (#523)

Bumps google.golang.org/protobuf from 1.31.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kumar Karthik Gosa <107932920+kumarkgosa@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
Co-authored-by: shefali-malhotra <91597668+shefali-malhotra@users.noreply.github.com>

* Bump golang.org/x/net from 0.17.0 to 0.23.0 in /tests/e2e (#545)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0.
- [Commits](golang/net@v0.17.0...v0.23.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update GitHub Actions (#547)

* update github actions

* add exclusion

* Fix related images auto update (#551)

* Fix auto update of related images during make bundle

* update comments in makefile

---------

Co-authored-by: panigs7 <spandita.panigrahi@dell.com>

* Fix invalid controllerstatus in ocp UI (#550)

* fix invalid controller status

* remove client status in apexclient as there is no client status in acc object

---------

Co-authored-by: panigs7 <spandita.panigrahi@dell.com>

* Set default container to driver (#543)

* Set default container to driver

* Add exception for the unfixed CVE

* Updated config version in some of the files

* Added default container config to the latest samples

* Updated image versions in manager.yaml

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kumar Karthik Gosa <107932920+kumarkgosa@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
Co-authored-by: shefali-malhotra <91597668+shefali-malhotra@users.noreply.github.com>
Co-authored-by: Chiman Jain <chimanjain15@gmail.com>
Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com>
Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com>
Co-authored-by: panigs7 <spandita.panigrahi@dell.com>
Co-authored-by: coulof <49235405+coulof@users.noreply.github.com>
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Set default container to driver (#543)
6b0bc82 
* Set default container to driver

* Add exception for the unfixed CVE
@mjsdell mjsdell deleted the default-container-driver branch October 17, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoppea2 hoppea2 hoppea2 approved these changes

@abhi16394 abhi16394 abhi16394 approved these changes

@donatwork donatwork donatwork approved these changes

@nitesh3108 nitesh3108 nitesh3108 left review comments

@shanmydell shanmydell shanmydell left review comments

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@coulof @donatwork @abhi16394 @hoppea2 @shanmydell @nitesh3108