Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KRV-1956 : Update go version to 1.17.4 #6

Merged
merged 1 commit into from
Jan 18, 2022
Merged

KRV-1956 : Update go version to 1.17.4 #6

merged 1 commit into from
Jan 18, 2022

Conversation

karthikk92
Copy link
Collaborator

@karthikk92 karthikk92 commented Jan 17, 2022 •
edited by gallacher
Loading

Description

Update go version to 1.17.4

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#159

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

installation of operator after go version change to 1.17: make run and make install
1

tdawe
tdawe previously approved these changes Jan 17, 2022
View reviewed changes
nb950
nb950 previously approved these changes Jan 17, 2022
View reviewed changes
rensyct
rensyct previously approved these changes Jan 18, 2022
View reviewed changes
@karthikk92 karthikk92 dismissed stale reviews from rensyct, nb950, and tdawe via fbdfe4b January 18, 2022 12:04
@karthikk92 karthikk92 force-pushed the go_version_change_1.17 branch from 4441157 to fbdfe4b Compare January 18, 2022 12:04
@rensyct rensyct merged commit 176f2b9 into main Jan 18, 2022
@rensyct rensyct deleted the go_version_change_1.17 branch March 21, 2022 09:18
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
GO version update to 1.17 (#6)
cfcbfef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdawe tdawe tdawe approved these changes

@rensyct rensyct rensyct approved these changes

@nb950 nb950 nb950 left review comments

@alikdell alikdell Awaiting requested review from alikdell

@medegw01 medegw01 Awaiting requested review from medegw01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karthikk92 @tdawe @nb950 @rensyct