-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple vaults for authorization v2 #656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaynafinocchiaro
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
HarishH-DELL,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
mjsdell,
nitesh3108,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7,
tdawe,
atye,
sharmilarama and
shanmydell
as code owners
August 12, 2024 19:45
atye
previously approved these changes
Aug 13, 2024
alikdell
previously approved these changes
Aug 14, 2024
shaynafinocchiaro
force-pushed
the
feature-1281-multiple-vaults
branch
from
August 15, 2024 00:25
5e8355d
to
c7328d3
Compare
atye
previously approved these changes
Aug 15, 2024
This sample needs to be updated with the new vault spec. |
alikdell
approved these changes
Aug 15, 2024
falfaroc
approved these changes
Aug 15, 2024
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
* updates for multiple vaults * update unit test samples * add unit tests * update storage crd * update manifests * use id in mount path * fix args * update sample * update cert comments * add ut for multiple vaults * add multiple vault e2e scenario * fix linting * fix linting * update storage sample --------- Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports multiple vault configurations during deployment with and without user certificates. Adds multiple vault unit tests and E2E scenario.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration