Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use common workflows #668

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Use common workflows #668

merged 6 commits into from
Aug 26, 2024

Conversation

eric-young
Copy link
Contributor

@eric-young eric-young commented Aug 26, 2024 •
edited
Loading

Description

Using common workflows defined in dell/common-github-actions

  • utilize common workflows
  • remove redundant workflows defined in this repo
  • added Makefile targets to test workflows (make check and/or make actions)
  • removed local config files for yamllint and golangci-lint as they now reside in the common-github-actions repo

GitHub Issues

None

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Extensive testing with ACT tool to validate workflows

@eric-young
use common workflows
54fa31f 
Use common workflows defined in dell/common-github-actions and remove redundand workflows
@eric-young
using workflows on main
2a41ded
@eric-young eric-young force-pushed the use-common-workflows branch from 90ca08b to cebfe7f Compare August 26, 2024 16:17
shaynafinocchiaro
shaynafinocchiaro reviewed Aug 26, 2024
View reviewed changes
.github/workflows/common-workflows.yaml Outdated Show resolved Hide resolved
pkg/modules/authorization.go Outdated Show resolved Hide resolved
@eric-young eric-young merged commit 85a4141 into main Aug 26, 2024
7 checks passed
@eric-young eric-young deleted the use-common-workflows branch August 26, 2024 17:55
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Use common workflows (#668)
a3bf480 
Use common workflows defined in dell/common-github-actions and remove redundant workflows
* disabling G115 with a comment in code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi16394 abhi16394 abhi16394 approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-young @abhi16394 @shaynafinocchiaro