Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for minimal manifests #685

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

harishp8889
Copy link
Contributor

@harishp8889 harishp8889 commented Sep 10, 2024

Description

Need for a simple and minimal manifest file using existing Operator CRD.
Changes include adding the below default values in the code:

  • Reverse proxy module for PowerMax driver
  • Disable sdc-monitor and health-monitor by default
  • Added the default check for kubelet config directory
  • Fixed issues with initContainer and MDM key not found issue in PowerFlex driver

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1449

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested against kubernetes cluster
  • Ran unit tests

cert-csi Test report for certify suite for ISCSI powerstore driver
report-test-run-bfdfd42b.txt

cert-csi Test report for certify suite Unity driver
unity-cert-csi-report.txt

cert-csi test report for PowerScale:
isilon-cert-csi-report.txt

cert-csi test report for PowerFlex:
PR-powerflex-sanity-logs.txt

Signed-off-by: Harish P <harish_p4@dell.com>
@meggm meggm merged commit 3074c0c into main Sep 10, 2024
7 checks passed
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
Signed-off-by: Harish P <harish_p4@dell.com>
@mjsdell mjsdell deleted the feature/minimal-manifests branch October 17, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants