Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the powerflex driver deployment issue #737

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Conversation

ashleyvjoy
Copy link
Contributor

@ashleyvjoy ashleyvjoy commented Oct 15, 2024

Description

There was a regression caused in powerflex driver deployment using minimal CR due to the changes that went in powerflex.go as part of this PR: #703. As a result the node pods were not coming up due to Error: couldn't find key MDM in Secret vxflexos/vxflexos-config

This PR is to address and fix the driver deployment issue with minimal CR

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
| dell/csm#1449 |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

  • Deployed the powerflex driver using both minimal CR and existing CR and verified that pods are up and running
bug-fix2

@harishp8889 harishp8889 merged commit b633b3e into main Oct 15, 2024
7 checks passed
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
Co-authored-by: Harish P <harishp8889@gmail.com>
@mjsdell mjsdell deleted the fix-pflex-minimal-cr branch October 17, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants