Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating published images to OCP 1.6.1 samples #738

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Updating published images to OCP 1.6.1 samples #738

merged 4 commits into from
Oct 15, 2024

Conversation

rajendraindukuri
Copy link
Collaborator

@rajendraindukuri rajendraindukuri commented Oct 15, 2024 •
edited
Loading

Description

  • Updated samples for OCP for 1.6.1 release with Redhat published images

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1478

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Made sure we are able to pull the newly added images with SHA for CSM 1.11.1
image
image

@rajendraindukuri rajendraindukuri marked this pull request as ready for review October 15, 2024 08:36
chimanjain
chimanjain approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@chimanjain chimanjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

harishp8889
harishp8889 approved these changes Oct 15, 2024
View reviewed changes
samples/ocp/1.6.1/connectivity_client_v110.yaml
image: docker.io/bitnami/kubectl@sha256:e9d32369b107d0ceeee228c4dc19eff372c26009f29a2fc8f22327508f608542
imagePullPolicy: IfNotPresent
- name: cert-persister
image: docker.io/dellemc/connectivity-cert-persister-k8s@sha256:aaa935f3ba99a91bf5f00c53de5cd69e23716645ea9690f050c4ed80834661fc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not migrating to quay.io?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harishp8889 this is for CSM 1.11.1. So that is not in scope.

@rajendraindukuri rajendraindukuri merged commit 36b2d0a into main Oct 15, 2024
14 checks passed
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell @harishp8889
Updating published images to OCP 1.6.1 samples (#738)
e7ec404 
Co-authored-by: Harish P <harishp8889@gmail.com>
@mjsdell mjsdell deleted the updating-1.6.1-published-ocp-samples branch October 17, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishp8889 harishp8889 harishp8889 approved these changes

@chimanjain chimanjain chimanjain approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@mgandharva mgandharva Awaiting requested review from mgandharva mgandharva is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajendraindukuri @harishp8889 @chimanjain