Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Fixes + ACC Removal #744

Merged
merged 1 commit into from
Oct 15, 2024
Merged

E2E Fixes + ACC Removal #744

merged 1 commit into from
Oct 15, 2024

Conversation

ChristianAtDell
Copy link
Contributor

Description

The primary goal of this PR is to get PowerFlex-related end-to-end testing scenarios passing with the latest code changes from the main branch. In addition, this branch includes @anathoodell effort to remove APEX Connectivity Client, as the testing code had a cross-dependency with that effort and the two branches were merged.

Previous PR for this work was located here: there were some issues with commit signing that blocked merge, so they have been brought to a new branch with a squash.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1507

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

All tests are run using the tests/e2e//run-e2e-test.sh --pflex command with special provisions made for a few that are still in alpha release. All tests are passed and logs with configurations are provided internally.

Copy link
Contributor

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L              G G G G     T T T T T T   M          M
L             G       G         T        M M      M M
L             G                 T        M  M   M   M
L             G   G G G         T        M    M     M
L             G       G         T        M          M
L L L L L L    G G G G          T        M          M

@ChristianAtDell ChristianAtDell merged commit 694ec5e into main Oct 15, 2024
7 checks passed
@ChristianAtDell ChristianAtDell deleted the priv/e2e-fixes-squash branch October 15, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants