[bug-1574]: Fix offline bundle registry references

[atye]

Description

The images.manifest file prior to 1.7.0, used to update the bundle with the private registry when preparing the bundle, contains references with and without docker.io for some images:

# grep isilon scripts/images.manifest
dellemc/csi-isilon:v2.11.0
docker.io/dellemc/csi-isilon:v2.11.0

If a file contains docker.io/dellemc/csi-isilon:v2.11.0, preparing the bundle will replace dellemc/csi-isilon:v2.11.0 with the private registry: docker.io/private-registry.com/csi-isilon:v2.11.0. Then, docker.io/dellemc/csi-isilon:v2.11.0 is replaced with the private registry but now that string has no matches and the file is left with the faulty registry.

This fix is having all image references specify the registry.

https://github.com/dell/csm-operator/blob/main/bundle/manifests/dell-csm-operator.clusterserviceversion.yaml and https://github.com/dell/csm-operator/blob/main/operatorconfig/driverconfig/common/default.yaml, used to gather image names when building the bundle, are updated to reference all images with the public registry. Since 1.7.0, all of our images now reference quay.io except sdc, otel-collector, and nginx. These are updated to reference docker.io.

The sample files are updated to reference the registry to be consistent with the images.manifest file.

Made csm-offline-bundle.sh executable.

Adds a new unit test for code coverage improvement for PR check.

Caveats:

• Since https://github.com/dell/csm-operator/blob/main/bundle/manifests/dell-csm-operator.clusterserviceversion.yaml references the latest images, the images.manifest file only has the latest images. The sample files for older releases are not updated with the private registry when preparing the bundle. This behavior has been in place since day one.
• The OCP sample files are not updated with the private registry due to the image names using the redhat registry and SHAs instead of tags. The user will update these sample files manually.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1574

Checklist:

• I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
• I have verified that new and existing unit tests pass locally with my changes
• I have not allowed coverage numbers to degenerate
• I have maintained at least 90% code coverage
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Built and prepared the bundle verifying that the private registry is correctly put in place in the yaml files that the user will use.
Built and installed the Operator via offline bundle.

[jooseppi-luna]

have you tried installing with the bundle? how have we verified that it works other than looking through it?

[atye]

have you tried installing with the bundle? how have we verified that it works other than looking through it?

@jooseppi-luna Yes, this works. The issue that the customer observed with the RELATED_IMAGES environment variables is resolved and installation is successful, with relevant files updated with the registry.