Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Powerflex e2e alternate values tests in OCP cluster #779

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

ashleyvjoy
Copy link
Contributor

@ashleyvjoy ashleyvjoy commented Nov 14, 2024

Description

In OCP clusters, the master nodes have the taint - key: "node-role.kubernetes.io/master" and not - key: "node-role.kubernetes.io/control-plane" so the controller pods are looking for a taint that doesn't exist in the E2E test scenarios that uses existing alternate values file. The toleration - key: "node-role.kubernetes.io/master" should be added. More details in the ticket

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
| dell/csm#1591 |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Executed the E2E scenarios that uses updated values file in OCP and K8S clusters and the tests pass. Results attached below:
e2e-test-logs.txt

@ChristianAtDell
Copy link
Contributor

Merged main into this branch and addressed merge conflict, which should bring UT coverage up unless code was added and not tested in this branch.

@ashleyvjoy ashleyvjoy merged commit bc222d3 into main Nov 20, 2024
7 checks passed
@ashleyvjoy ashleyvjoy deleted the fix-krv-30363 branch November 20, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants