Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read zone information from PowerFlex secret #810

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

EvgenyUglov
Copy link
Contributor

@EvgenyUglov EvgenyUglov commented Dec 3, 2024

Description

PR adds the method to read the zoning information from the PowerFlex array secret

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1613

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • unit tests
# go test ./... -cover -count=1
        github.com/dell/csm-operator            coverage: 0.0% of statements
        github.com/dell/csm-operator/api/v1             coverage: 0.0% of statements
        github.com/dell/csm-operator/core               coverage: 0.0% of statements
?       github.com/dell/csm-operator/pkg/constants      [no test files]
        github.com/dell/csm-operator/core/semver                coverage: 0.0% of statements
        github.com/dell/csm-operator/pkg/logger         coverage: 0.0% of statements
        github.com/dell/csm-operator/tests/shared               coverage: 0.0% of statements
        github.com/dell/csm-operator/tests/shared/clientgoclient                coverage: 0.0% of statements
        github.com/dell/csm-operator/tests/shared/crclient              coverage: 0.0% of statements
ok      github.com/dell/csm-operator/controllers        55.926s coverage: 89.1% of statements
ok      github.com/dell/csm-operator/k8s        0.103s  coverage: 90.3% of statements
ok      github.com/dell/csm-operator/pkg/drivers        0.396s  coverage: 96.1% of statements
ok      github.com/dell/csm-operator/pkg/modules        2.397s  coverage: 89.7% of statements
ok      github.com/dell/csm-operator/pkg/resources/configmap    0.094s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/resources/csidriver    0.105s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/resources/daemonset    0.079s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/resources/deployment   0.069s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/resources/rbac 0.070s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/resources/serviceaccount       0.068s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/utils  3.158s  coverage: 81.9% of statements
  • E2E tests (PowerFlex suite only)

@EvgenyUglov EvgenyUglov changed the title Pub/powerflex zone from secret Read zone information from PowerFlex secret Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants