Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: CSM Operator not deleting the deployment and daemon sets after deleting the CSM #815

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

riya-kaushal7997
Copy link
Contributor

@riya-kaushal7997 riya-kaushal7997 commented Dec 6, 2024

Description

After deleting the CSM the Operator not clearing the pods. When driver is deployed without forceRemoveDriver field in the CR, it sets forceRemoveDriver to false by default. Hence the driver pods still persists even after deleting CSM.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1604

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.

The operator e2e tests were executed successfully. Full log attached in Jira ticket.

  • Executed tests to install Powermax, Powerstore, Powerflex, Powerscale, and Unity (as Minimal, Standalone)
  • Executed tests for Powermax, Powerstore, Powerflex, Powerscale and Unity with empty forceRemoveDriver (Minimal)
  • Executed tests for Powermax, Powerstore, Powerflex, Powerscale and Unity with forceRemoveDriver set to false (Minimal)

@riya-kaushal7997 riya-kaushal7997 marked this pull request as draft December 6, 2024 10:04
Copy link
Contributor

@harishp8889 harishp8889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description and add the appropriate e2e as per our discussion.

api/v1/zz_generated.deepcopy.go Show resolved Hide resolved
@riya-kaushal7997 riya-kaushal7997 marked this pull request as ready for review December 11, 2024 13:36
@riya-kaushal7997 riya-kaushal7997 merged commit 4f9b0fd into main Dec 13, 2024
7 checks passed
@riya-kaushal7997 riya-kaushal7997 deleted the bugfix/set_default_forceRemoveDriver_true branch December 13, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants