Powerflex secret zone validation #833

anathoodell · 2024-12-19T02:39:28Z

Description

CSM-Operator Zone Validation function is added to validate zone configuration prior to installation (pre-checks). If the Zone validation fails, the CSM object remains in a failed state.

Validation is limited to the powerflex secret only. No node label checks are done.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1613

Checklist:

I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
I have verified that new and existing unit tests pass locally with my changes
I have not allowed coverage numbers to degenerate
I have maintained at least 90% code coverage
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have maintained backward compatibility
I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Unit tests added and run to maintain coverage numbers. Basic pflex E2E scenarios run as well.

Directly on a cluster with 2 nodes.
Test B

if zone validation fails - this event is logged in the csm cr.

drivers.ExtractZones. Fixed up existing unit-tests to pass around a proper secret, rather than the "csm" value currently used, as this causes the ExtractZones() to fail on parsing during unit-testing.

key-value pair. ZoneValidation function filled in to continue correct zone validation. Unit Test code updated including infra client List code to match on labels.

…t-test bring up back to 90.0% coverage.

node labels anymore. Removing the directly associated unit test code as well. Fixing powerflex validate zone code to check that all arrays have zone detail if there is at least one array with zone detail.

controllers/csm_controller.go

pkg/drivers/powerflex.go

tests/shared/common.go

JacobGros

LGTM

pkg/drivers/powerflex.go

labelValue or Name are either not specified or are empty values. Cleaned up test code and added test cases for these scenarios.

pkg/drivers/powerflex.go

anathoodell added 16 commits December 10, 2024 13:45

Adding WIP ZoneValidation() to PowerFlex PreChecks that calls into

53d1450

drivers.ExtractZones. Fixed up existing unit-tests to pass around a proper secret, rather than the "csm" value currently used, as this causes the ExtractZones() to fail on parsing during unit-testing.

GetMatchingNodes() using HasLabes() to match on Key rather than

b7b9198

key-value pair. ZoneValidation function filled in to continue correct zone validation. Unit Test code updated including infra client List code to match on labels.

2 code fixes, unit-test fakeclient fixes and ut augmentation, and uni…

967ba93

…t-test bring up back to 90.0% coverage.

Updated client.go.

3573bd1

Updating client.go.

03f67f4

lint updates.

ee5355c

lint update on csm controller.

d238c96

fixing gofumpt errors.

580c5da

Merge branch 'main' into usr/anathoodell/zonevalidation

33834fd

Removing node label code since we do not need to validate against

7a2560e

node labels anymore. Removing the directly associated unit test code as well. Fixing powerflex validate zone code to check that all arrays have zone detail if there is at least one array with zone detail.

Updates to infra test code.

cfb6a41

Removing redundant namespace param.

fee6efc

Remove namespace param from prechecks and callers.

03db965

Removing namespace param from Precheck callers in test code.

3529b41

fix golang lint error.

aa2da54

gofumpt file.

326523d

anathoodell marked this pull request as ready for review December 19, 2024 04:00

anathoodell requested review from abhi16394, mbasha-dell, alikdell, bharathsreekanth, chimanjain, coulof, Deepak-Ghivari, gallacher, gilltaran, harishp8889, HarishH-DELL, JacobGros and jooseppi-luna as code owners December 19, 2024 04:00