Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add csm namespace label to components #847

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Add csm namespace label to components #847

merged 2 commits into from
Jan 10, 2025

Conversation

rajendraindukuri
Copy link
Collaborator

@rajendraindukuri rajendraindukuri commented Jan 7, 2025 •
edited
Loading

Description

Added csmNameSpace label on all the deployment/daemonset for CSM Operator in order to filter CSM related pods from the others

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1668

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

  • Manually Tested the fix and also ran e2e tests for drivers
  • Manually Tested the fix for modules and also ran e2e for replication, authorization v1 authorization v2, app mobility

All details are provided in the Jira ECS01C-2

@rajendraindukuri rajendraindukuri marked this pull request as ready for review January 9, 2025 10:59
@rajendraindukuri rajendraindukuri force-pushed the add-csm-namespace-label-to-components branch from e1bcc85 to 4bbc89d Compare January 9, 2025 11:12
bpjain2004
bpjain2004 reviewed Jan 9, 2025
View reviewed changes
controllers/csm_controller.go
Comment on lines +463 to +467
if !p.ObjectMeta.DeletionTimestamp.IsZero() {
log.Debugw("driver delete invoked", "stopping pod with name", p.Name)
return
}
log.Infow("pod modified for driver", "name", p.Name)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix these indentations.

@rajendraindukuri rajendraindukuri force-pushed the add-csm-namespace-label-to-components branch from 9ac91f6 to aa7953a Compare January 9, 2025 13:24
@prablr79
Copy link

prablr79 commented Jan 9, 2025

@rajendraindukuri you should be all set now!

@prablr79 prablr79 linked an issue Jan 9, 2025 that may be closed by this pull request
[BUG]: CSM-Operator is reconciling non CSM pods dell/csm#1668
Closed
@rajendraindukuri rajendraindukuri force-pushed the add-csm-namespace-label-to-components branch from aa7953a to 350d0e7 Compare January 10, 2025 04:55
@rajendraindukuri rajendraindukuri force-pushed the add-csm-namespace-label-to-components branch from 350d0e7 to ceffe66 Compare January 10, 2025 05:03
@rajendraindukuri rajendraindukuri merged commit 4f2abf7 into main Jan 10, 2025
7 checks passed
@rajendraindukuri rajendraindukuri deleted the add-csm-namespace-label-to-components branch January 10, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimanjain chimanjain chimanjain approved these changes

@bpjain2004 bpjain2004 bpjain2004 approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@mgandharva mgandharva Awaiting requested review from mgandharva mgandharva is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: CSM-Operator is reconciling non CSM pods
5 participants
@rajendraindukuri @prablr79 @chimanjain @bpjain2004 @nitesh3108