Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix]: Powerflex minimal manifest issue #855

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

mgandharva
Copy link
Contributor

@mgandharva mgandharva commented Jan 10, 2025

Description

Added validation for common and image for Powerflex minimal manifest

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1671

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran E2E for powerflex
  • image

@prablr79
Copy link

@mgandharva update all details here, missing defect and checklist.

Comment on lines +76 to +78
if cr.Spec.Driver.Replicas != 0 {
controllerYAML.Deployment.Spec.Replicas = &cr.Spec.Driver.Replicas
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really required?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, because with minimal sample files, the replicas can be 0 in the CR. In this case, we want to use the default values in operatorconfig.

Without that check, the minimal manifests would deploy the driver pods w/o the deployment pods

@alikdell alikdell merged commit 6fd8269 into main Jan 10, 2025
7 checks passed
@alikdell alikdell deleted the grosnj1/fix-min-pflex branch January 10, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants