-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix]: Powerflex minimal manifest issue #855
Conversation
@mgandharva update all details here, missing defect and checklist. |
if cr.Spec.Driver.Replicas != 0 { | ||
controllerYAML.Deployment.Spec.Replicas = &cr.Spec.Driver.Replicas | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, because with minimal sample files, the replicas can be 0 in the CR. In this case, we want to use the default values in operatorconfig.
Without that check, the minimal manifests would deploy the driver pods w/o the deployment pods
Description
Added validation for common and image for Powerflex minimal manifest
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration