Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the versions for reverseproxy to v2.12.0 #864

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Updated the versions for reverseproxy to v2.12.0 #864

merged 2 commits into from
Jan 16, 2025

Conversation

jackieung-dell
Copy link
Contributor

@jackieung-dell jackieung-dell commented Jan 15, 2025 •
edited by jooseppi-luna
Loading

Description

Reverted the csipowermax-reverseproxy image version to v2.12.0
csi-reverseproxy image was updated by mistake in this PR (#859) to v2.13.0.
so reverting it back in the present PR.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
1559

Checklist:

  • [x ] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • [x ] I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Operator e2e tests are broken right now, but there is a PR going up to fix them, so we will let the pipeline run them tonight and check the results in the morning to make sure everything is OK.

Installed powermax driver and ran cert-csi test

image

Cert-csi run to test powermax deployment :

[root@master-1-jkPwn32okjktZ cert-csi]# ./cert-csi test vio --sc powermax-iscsi --chainLength 1 --chainNumber 1
[2025-01-15 23:42:55]  INFO Starting cert-csi; ver. 1.6.0
[2025-01-15 23:42:55]  INFO Using EVENT observer type
[2025-01-15 23:42:55]  INFO Using config from /etc/kubernetes/admin.conf
[2025-01-15 23:42:55]  INFO Successfully loaded config. Host: https://0.0.0.0
[2025-01-15 23:42:55]  INFO Created new KubeClient
[2025-01-15 23:42:55]  INFO Running 1 iteration(s)
[2025-01-15 23:42:55]  INFO     *** ITERATION NUMBER 1 ***
[2025-01-15 23:42:55]  INFO Starting VolumeIoSuite with powermax-iscsi storage class
[2025-01-15 23:42:55]  INFO Successfully created namespace volumeio-test-999d632d
[2025-01-15 23:42:55]  INFO Using default number of volumes
[2025-01-15 23:42:55]  INFO Using default image: quay.io/centos/centos:latest
[2025-01-15 23:42:55]  INFO Creating IO pod
[2025-01-15 23:42:55]  INFO Waiting for pod iowriter-test-fm4xm to be READY
[2025-01-15 23:43:47]  INFO Executing command: [/bin/bash -c dd if=/dev/urandom bs=1M count=128 oflag=sync > /data0/writer-0.data]
[2025-01-15 23:43:48]  INFO Executing command: [/bin/bash -c sha512sum /data0/writer-0.data > /data0/writer-0.sha512]
[2025-01-15 23:43:58]  INFO Waiting until no Volume Attachments with PV  left
[2025-01-15 23:43:58]  INFO VolumeAttachment deleted
[2025-01-15 23:43:58]  INFO Deleting all resources in namespace volumeio-test-999d632d
[2025-01-15 23:44:10]  INFO Namespace volumeio-test-999d632d was deleted in 12.010119301s
[2025-01-15 23:44:15]  INFO SUCCESS: VolumeIoSuite in 1m20.088428926s
[2025-01-15 23:44:15]  INFO Started generating reports...
Collecting metrics
1 / 1 [----------------------------------------------------------------------------------------------------------------------------------------] 100.00% ? p/s
[2025-01-15 23:44:15]  INFO Started generating reports...
Collecting metrics
1 / 1 [----------------------------------------------------------------------------------------------------------------------------------------] 100.00% ? p/s
Generating plots
1 / 1 [----------------------------------------------------------------------------------------------------------------------------------------] 100.00% ? p/s
[2025-01-15 23:44:15]  WARN No ResourceUsageMetrics provided
[2025-01-15 23:44:15] ERROR no ResourceUsageMetrics provided
report-test-run-a42eb31a:
Name: test-run-a42eb31a
Host: https://10.247.142.122:6443
StorageClass: powermax-iscsi
Minimum and Maximum EntityOverTime charts:

/root/.cert-csi/reports/test-run-a42eb31a/PodsCreatingOverTime.png

/root/.cert-csi/reports/test-run-a42eb31a/PodsReadyOverTime.png

/root/.cert-csi/reports/test-run-a42eb31a/PodsTerminatingOverTime.png

/root/.cert-csi/reports/test-run-a42eb31a/PvcsCreatingOverTime.png

/root/.cert-csi/reports/test-run-a42eb31a/PvcsBoundOverTime.png

Tests:
--------------------------------------------------------------
1. TestCase: VolumeIoSuite
            Started:   2025-01-15 23:42:55.603605982 -0500 -0500
            Ended:     2025-01-15 23:44:15.692519369 -0500 -0500
            Result:    SUCCESS

            Stage metrics:
                    PVCAttachment:
                        Avg: 6.586962485s
                        Min: 6.586962485s
                        Max: 6.586962485s
                        Histogram:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PVCAttachment.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PVCAttachment_boxplot.png
                    PVCBind:
                        Avg: 2.885142224s
                        Min: 2.885142224s
                        Max: 2.885142224s
                        Histogram:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PVCBind.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PVCBind_boxplot.png
                    PVCCreation:
                        Avg: 9.614873456s
                        Min: 9.614873456s
                        Max: 9.614873456s
                        Histogram:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PVCCreation.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PVCCreation_boxplot.png
                    PVCDeletion:
                        Avg: 10.264415ms
                        Min: 10.264415ms
                        Max: 10.264415ms
                        Histogram:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PVCDeletion.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PVCDeletion_boxplot.png
                    PVCUnattachment:
                        Avg: 2.115063915s
                        Min: 2.115063915s
                        Max: 2.115063915s
                        Histogram:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PVCUnattachment.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PVCUnattachment_boxplot.png
                    PodCreation:
                        Avg: 50.228593228s
                        Min: 50.228593228s
                        Max: 50.228593228s
                        Histogram:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PodCreation.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PodCreation_boxplot.png
                    PodDeletion:
                        Avg: 8.540261457s
                        Min: 8.540261457s
                        Max: 8.540261457s
                        Histogram:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PodDeletion.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/PodDeletion_boxplot.png
                        EntityNumberOverTime:
        /root/.cert-csi/reports/test-run-a42eb31a/VolumeIoSuite1/EntityNumberOverTime.png

[2025-01-15 23:44:16]  INFO Avg time of a run:   63.25s
[2025-01-15 23:44:16]  INFO Avg time of a del:   12.01s
[2025-01-15 23:44:16]  INFO Avg time of all:     80.08s
[2025-01-15 23:44:16]  INFO During this run 100.0% of suites succeeded

jooseppi-luna
jooseppi-luna requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please provide an actual GH issue link, not just the plaintext number
  • Please describe any testing you did

jooseppi-luna
jooseppi-luna approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this is fixing a breaking change in operator -- don't want to wait until everything else is fixed to merge this in

Thank you!

santhoshatdell
santhoshatdell approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@santhoshatdell santhoshatdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to revert the changes made accidently in PR #859 (comment)

abhi16394
abhi16394 requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@abhi16394 abhi16394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please build operator image and install any driver
run cert-csi and verify the changes

@jooseppi-luna jooseppi-luna merged commit a3202c6 into main Jan 16, 2025
7 checks passed
@jooseppi-luna jooseppi-luna deleted the reverseproxyVersion branch January 16, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshatdell santhoshatdell santhoshatdell approved these changes

@abhi16394 abhi16394 abhi16394 approved these changes

@jooseppi-luna jooseppi-luna jooseppi-luna approved these changes

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@mgandharva mgandharva Awaiting requested review from mgandharva mgandharva is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackieung-dell @jooseppi-luna @abhi16394 @santhoshatdell @anandrajak1