Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip RG status poll/update if any action is being executed #69

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

santhoshatdell
Copy link
Contributor

@santhoshatdell santhoshatdell commented Dec 14, 2022

Description

When RG status gets updated (as part of regular monitoring) when an action is in progress, the action result update fails. Due to that, the action gets executed again. So RG status polling is skipped when an action is being executed and the action anyways update the RG status at the end.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#558
dell/csm#532

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Tested all PowerScale replication actions and no issues are detected. Monitored the log w.r.t action and RG status poll.
RG status poll log times.txt

Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@santhoshatdell santhoshatdell merged commit e51e230 into main Jan 6, 2023
@santhoshatdell santhoshatdell deleted the rg-monitoring-fix branch January 6, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants