Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: cert-csi - cannot configure image locations #1059

Closed
rishabhatdell opened this issue Nov 28, 2023 · 3 comments
Closed

[BUG]: cert-csi - cannot configure image locations #1059

rishabhatdell opened this issue Nov 28, 2023 · 3 comments
Assignees
Labels
area/cert-csi Issues pertaining to Cert CSI type/bug Something isn't working. This is the default label associated with a bug issue.
Milestone

Comments

@rishabhatdell
Copy link

rishabhatdell commented Nov 28, 2023

Bug Description

The cert-csi binary and docker image have some hardcoded values for the image urls, such as https://github.com/dell/cert-csi/blob/main/pkg/testcore/config.go#L146. This makes it difficult to change the image name without rebuilding the entire binary and docker image. This can cause problems when deploying cert-csi on different environments or platforms. We need to find a way to make the image name configurable and dynamic so that we can use different images for different scenarios.

Logs

N/A

Screenshots

No response

Additional Environment Information

No response

Steps to Reproduce

N/A

Expected Behavior

Should be able to pull images from given artifactory

CSM Driver(s)

N/A

Installation Type

No response

Container Storage Modules Enabled

No response

Container Orchestrator

N/A

Operating System

N/A

@rishabhatdell rishabhatdell added needs-triage Issue requires triage. type/bug Something isn't working. This is the default label associated with a bug issue. labels Nov 28, 2023
@csmbot
Copy link
Collaborator

csmbot commented Nov 28, 2023

@rishabhatdell: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and respond appropriately.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at container.storage.modules@dell.com.

@suryagupta4 suryagupta4 added area/cert-csi Issues pertaining to Cert CSI and removed needs-triage Issue requires triage. labels Nov 28, 2023
@suryagupta4 suryagupta4 added this to the v1.9.0 milestone Nov 28, 2023
@suryagupta4
Copy link

link: 18669

@gallacher
Copy link
Contributor

@rishabhatdell and @suryagupta4 - please ensure there is an accompanying documentation pull request for this. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cert-csi Issues pertaining to Cert CSI type/bug Something isn't working. This is the default label associated with a bug issue.
Projects
None yet
Development

No branches or pull requests

4 participants